New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

allow for persistent l2arc #925

Closed
cwedgwood opened this Issue Sep 2, 2012 · 11 comments

Comments

Projects
None yet
8 participants
@cwedgwood
Contributor

cwedgwood commented Sep 2, 2012

https://groups.google.com/a/zfsonlinux.org/forum/?fromgroups=#!topic/zfs-discuss/eSYYLdx73r4

References request and a suggestion on how it might be done.

@mlidbom

This comment has been minimized.

mlidbom commented May 18, 2013

Seems there's an implementation of this in illumos going through final testing now:
Feature Request
Design Document
Patches
I would love to see it implemented for linux.

@behlendorf

This comment has been minimized.

Member

behlendorf commented Jun 3, 2013

Once it's merged in to Illumos in it's final form and soaks for a while I'm sure we'll pick this up.

@yshui

This comment has been minimized.

Contributor

yshui commented Oct 31, 2013

Are there anyone interested in doing this? Otherwise I'll try porting and keeping track of this patch set.

@behlendorf

This comment has been minimized.

Member

behlendorf commented Oct 31, 2013

@yshui Nobody on the Linux side I know if working on this right now. If you can port the upstream patches and keep them up current that would be great. I'm sure @skiselkov would appreciate any additional testing and feedback you can provide.

yshui added a commit to yshui/zfs that referenced this issue Nov 8, 2013

3525 persistent l2arc.
For details, see:

https://www.illumos.org/issues/3525

Close zfsonlinux#925

Ported-by: Yuxuan Shui <yshuiv7@gmail.com>

yshui added a commit to yshui/zfs that referenced this issue Nov 8, 2013

3525 persistent l2arc.
For details, see:

https://www.illumos.org/issues/3525

Close zfsonlinux#925

Ported-by: Yuxuan Shui <yshuiv7@gmail.com>

yshui added a commit to yshui/zfs that referenced this issue Nov 23, 2013

3525 persistent l2arc.
For details, see: https://www.illumos.org/issues/3525

v2: Change two KM_SLEEP to KM_PUSHPAGE.

Close zfsonlinux#925

Ported-by: Yuxuan Shui <yshuiv7@gmail.com>

yshui added a commit to yshui/zfs that referenced this issue Nov 23, 2013

3525 persistent l2arc.
For details, see: https://www.illumos.org/issues/3525

v2: Change two KM_SLEEP to KM_PUSHPAGE.

Close zfsonlinux#925

Ported-by: Yuxuan Shui <yshuiv7@gmail.com>

yshui added a commit to yshui/zfs that referenced this issue Nov 26, 2013

3525 persistent l2arc.
For details, see: https://www.illumos.org/issues/3525

v2: Change two KM_SLEEP to KM_PUSHPAGE.
v3: Change one more KM_SLEEP.

Close zfsonlinux#925

Ported-by: Yuxuan Shui <yshuiv7@gmail.com>

yshui added a commit to yshui/zfs that referenced this issue Aug 23, 2014

3525 persistent l2arc.
For details, see: https://www.illumos.org/issues/3525

v2: Change two KM_SLEEP to KM_PUSHPAGE.
v3: Change one more KM_SLEEP.

Close zfsonlinux#925

Ported-by: Yuxuan Shui <yshuiv7@gmail.com>

yshui added a commit to yshui/zfs that referenced this issue Aug 23, 2014

3525 persistent l2arc.
For details, see: https://www.illumos.org/issues/3525

v2: Change two KM_SLEEP to KM_PUSHPAGE.
v3: Change one more KM_SLEEP.

Close zfsonlinux#925

Ported-by: Yuxuan Shui <yshuiv7@gmail.com>

yshui added a commit to yshui/zfs that referenced this issue Aug 23, 2014

3525 persistent l2arc.
For details, see: https://www.illumos.org/issues/3525

v2: Change two KM_SLEEP to KM_PUSHPAGE.
v3: Change one more KM_SLEEP.

Close zfsonlinux#925

Ported-by: Yuxuan Shui <yshuiv7@gmail.com>

yshui added a commit to yshui/zfs that referenced this issue Aug 23, 2014

3525 persistent l2arc.
For details, see: https://www.illumos.org/issues/3525

v2: Change two KM_SLEEP to KM_PUSHPAGE.
v3: Change one more KM_SLEEP.

Close zfsonlinux#925

Ported-by: Yuxuan Shui <yshuiv7@gmail.com>

yshui added a commit to yshui/zfs that referenced this issue Aug 23, 2014

3525 persistent l2arc.
For details, see: https://www.illumos.org/issues/3525

v2: Change two KM_SLEEP to KM_PUSHPAGE.
v3: Change one more KM_SLEEP.

Close zfsonlinux#925

Ported-by: Yuxuan Shui <yshuiv7@gmail.com>

yshui added a commit to yshui/zfs that referenced this issue Aug 24, 2014

3525 persistent l2arc.
For details, see: https://www.illumos.org/issues/3525

v2: Change two KM_SLEEP to KM_PUSHPAGE.
v3: Change one more KM_SLEEP.
v4: Fix alignment of log block.

Close zfsonlinux#925

Ported-by: Yuxuan Shui <yshuiv7@gmail.com>

yshui added a commit to yshui/zfs that referenced this issue Aug 24, 2014

3525 persistent l2arc.
For details, see: https://www.illumos.org/issues/3525

v2: Change two KM_SLEEP to KM_PUSHPAGE.
v3: Change one more KM_SLEEP.
v4: Fix alignment of log block.

Close zfsonlinux#925

Ported-by: Yuxuan Shui <yshuiv7@gmail.com>

yshui added a commit to yshui/zfs that referenced this issue Aug 24, 2014

3525 persistent l2arc.
For details, see: https://www.illumos.org/issues/3525

v2: Change two KM_SLEEP to KM_PUSHPAGE.
v3: Change one more KM_SLEEP.
v4: The original implementation seems to assume that compressed log buf
size is aligned with SPA_MINBLOCKSIZE, which is not always the case.
This might result in truncated log bufs. To fix this and maintain
compatibility with the original implementation, disabling compression
seems to be the only way.
v5: Fix style.

Close zfsonlinux#925

Ported-by: Yuxuan Shui <yshuiv7@gmail.com>

yshui added a commit to yshui/zfs that referenced this issue Aug 24, 2014

3525 persistent l2arc.
For details, see: https://www.illumos.org/issues/3525

v2: Change two KM_SLEEP to KM_PUSHPAGE.
v3: Change one more KM_SLEEP.
v4: The original implementation seems to assume that compressed log buf
size is aligned with SPA_MINBLOCKSIZE, which is not always the case.
This might result in truncated log bufs. To fix this and maintain
compatibility with the original implementation, disabling compression
seems to be the only way.
v5: Fix style.

Close zfsonlinux#925

Ported-by: Yuxuan Shui <yshuiv7@gmail.com>

yshui added a commit to yshui/zfs that referenced this issue Aug 25, 2014

3525 persistent l2arc.
For details, see: https://www.illumos.org/issues/3525

v2: Change two KM_SLEEP to KM_PUSHPAGE.
v3: Change one more KM_SLEEP.
v4: Fix log buffer alignment.
v5: Fix style.

Close zfsonlinux#925

Ported-by: Yuxuan Shui <yshuiv7@gmail.com>

yshui added a commit to yshui/zfs that referenced this issue Aug 25, 2014

3525 persistent l2arc.
For details, see: https://www.illumos.org/issues/3525

v2: Change two KM_SLEEP to KM_PUSHPAGE.
v3: Change one more KM_SLEEP.
v4: Fix log buffer alignment in l2arc_dev_log_commit.
v5: Fix style.
v6: l2arc vdev can go away, remove ASSERT in l2arc_spa_rebuild_start.

Close zfsonlinux#925

Ported-by: Yuxuan Shui <yshuiv7@gmail.com>

edillmann added a commit to edillmann/zfs that referenced this issue Sep 4, 2014

3525 persistent l2arc.
For details, see: https://www.illumos.org/issues/3525

v2: Change two KM_SLEEP to KM_PUSHPAGE.
v3: Change one more KM_SLEEP.
v4: Fix log buffer alignment in l2arc_dev_log_commit.
v5: Fix style.
v6: l2arc vdev can go away, remove ASSERT in l2arc_spa_rebuild_start.

Close zfsonlinux#925

Ported-by: Yuxuan Shui <yshuiv7@gmail.com>

yshui added a commit to yshui/zfs that referenced this issue Sep 7, 2014

3525 persistent l2arc.
For details, see: https://www.illumos.org/issues/3525

v2: Change two KM_SLEEP to KM_PUSHPAGE.
v3: Change one more KM_SLEEP.
v4: Fix log buffer alignment in l2arc_dev_log_commit.
v5: Fix style.
v6: l2arc vdev can go away, remove ASSERT in l2arc_spa_rebuild_start.

Close zfsonlinux#925

Ported-by: Yuxuan Shui <yshuiv7@gmail.com>

@behlendorf behlendorf modified the milestones: 0.8.0, 0.6.4 Oct 6, 2014

@grahamperrin

This comment has been minimized.

grahamperrin commented Sep 6, 2015

From irc://chat.freenode.net/#illumos today:

nexenta might have some kind of implementation for it, i think.

@kernelOfTruth

This comment has been minimized.

Contributor

kernelOfTruth commented Sep 6, 2015

@grahamperrin thanks for the pointer !

Nexenta/illumos-nexenta@f0a9ee9 NEX-3514 Implement persistent L2ARC

Nexenta/illumos-nexenta@8872632 NEX-3514 Implement persistent L2ARC - fix build breakage in libzpool.

Nexenta/illumos-nexenta@9498bb1 NEX-3514 Implement persistent L2ARC - fix build breakage in libzpool (v2).

https://github.com/Nexenta/illumos-nexenta/commits/master?page=4

@kerberizer

This comment has been minimized.

kerberizer commented Nov 4, 2015

illumos 3525 is now in code review.

@cwedgwood

This comment has been minimized.

Contributor

cwedgwood commented Feb 14, 2017

Updated progress at https://reviews.csiden.org/r/267/

@behlendorf behlendorf closed this Feb 15, 2017

@mailinglists35

This comment has been minimized.

mailinglists35 commented Dec 28, 2017

@behlendorf what does closing of this mean? it has been integrated/ported already? it will never be?

@behlendorf

This comment has been minimized.

Member

behlendorf commented Dec 28, 2017

The intention was to pick up this work once it was finalized and merged for illumos.

@mailinglists35

This comment has been minimized.

mailinglists35 commented Jan 4, 2018

@behlendorf could you mark it a duplicate of #3744, even if this is chronologicallty the oldest?
I had to read the other one to understand what's going on, as your reply was not really clearly explaining why it was closed.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment