Skip to content

Loading…

zfs_scrub_limit tunable is not used anywhere #1444

Closed
wants to merge 1 commit into from

1 participant

@imp
imp commented

As a part of scrub/resilver tuning zfs_scrub_limit fell out of use,
but the definition of the variable remained in place.
Moreover various guides still (misleadingly) mention it as a way
to influence resilver/scrub behavior.
This commit removes its finally.

Signed-off-by: Cyril Plisko cyril.plisko@mountall.com

@imp imp zfs_scrub_limit tunable is not used anywhere
As a part of scrub/resilver tuning zfs_scrub_limit fell out of use,
but the definition of the variable remained in place.
Moreover various guides still (misleadingly) mention it as a way
to influence resilver/scrub behavior.
This commit removes its finally.

Signed-off-by: Cyril Plisko <cyril.plisko@mountall.com>
cdf11e7
@behlendorf behlendorf added a commit that closed this pull request
@imp imp zfs_scrub_limit tunable is not used anywhere
As a part of scrub/resilver tuning zfs_scrub_limit fell out of use,
but the definition of the variable remained in place.
Moreover various guides still (misleadingly) mention it as a way
to influence resilver/scrub behavior.
This commit removes its finally.

Signed-off-by: Cyril Plisko <cyril.plisko@mountall.com>
Signed-off-by: Brian Behlendorf <behlendorf1@llnl.gov>
Closes #1444
4f34b3b
@behlendorf behlendorf closed this in 4f34b3b
@unya unya added a commit to unya/zfs that referenced this pull request
@imp imp zfs_scrub_limit tunable is not used anywhere
As a part of scrub/resilver tuning zfs_scrub_limit fell out of use,
but the definition of the variable remained in place.
Moreover various guides still (misleadingly) mention it as a way
to influence resilver/scrub behavior.
This commit removes its finally.

Signed-off-by: Cyril Plisko <cyril.plisko@mountall.com>
Signed-off-by: Brian Behlendorf <behlendorf1@llnl.gov>
Closes #1444
2f37fd7
@imp imp deleted the imp:no_zfs_scrub_limit branch
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Commits on May 6, 2013
  1. @imp

    zfs_scrub_limit tunable is not used anywhere

    imp committed
    As a part of scrub/resilver tuning zfs_scrub_limit fell out of use,
    but the definition of the variable remained in place.
    Moreover various guides still (misleadingly) mention it as a way
    to influence resilver/scrub behavior.
    This commit removes its finally.
    
    Signed-off-by: Cyril Plisko <cyril.plisko@mountall.com>
This page is out of date. Refresh to see the latest.
Showing with 0 additions and 6 deletions.
  1. +0 −6 module/zfs/vdev.c
View
6 module/zfs/vdev.c
@@ -61,9 +61,6 @@ static vdev_ops_t *vdev_ops_table[] = {
NULL
};
-/* maximum scrub/resilver I/O queue per leaf vdev */
-int zfs_scrub_limit = 10;
-
/*
* Given a vdev type, return the appropriate ops vector.
*/
@@ -3241,7 +3238,4 @@ EXPORT_SYMBOL(vdev_degrade);
EXPORT_SYMBOL(vdev_online);
EXPORT_SYMBOL(vdev_offline);
EXPORT_SYMBOL(vdev_clear);
-
-module_param(zfs_scrub_limit, int, 0644);
-MODULE_PARM_DESC(zfs_scrub_limit, "Max scrub/resilver I/O per leaf vdev");
#endif
Something went wrong with that request. Please try again.