Fix typo in commit b83e3e48c9b183a80dd00eb6c7431a1cbc7d89c9 #1884
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
There's a missing semicolon in the first hunk of this commit in config/kernel-bdi.m4. This results in the test always failing. The effects were noticed when rrdtool, a tool which modifies files by mmap() and msync(), would have data never get saved to disk in spite of the files working while the mounted filesystem remains mounted.
|
Here's a crazy experiment for the broken version. Use an mmap-based tool to modify data on disk. Take a snapshot. The file in the snapshot and the file in the filesystem have different contents. Export and re-import the pool. They now have the same contents with the effects of the mmap having been reversed. I've also noticed that /proc/meminfo shows dirty data which will never go away until the pool is exported, though that's less thoroughly tested. |
I can't believe I missed that...
|
I think I broke github trying to combine both commits into a single one within the same pull request. Let's try this again with less fail. |
unya
pushed a commit
to unya/zfs
that referenced
this pull request
Dec 13, 2013
…fs#3060, openzfs#3061, openzfs#3093 1884 Empty "used" field for zfs *space commands 3028 zfs {group,user}space -n prints (null) instead of numeric GID/UID 3048 zfs {user,group}space [-s|-S] is broken 3049 zfs {user,group}space -t doesn't really filter the results 3060 zfs {user,group}space -H output isn't tab-delimited 3061 zfs {user,group}space -o doesn't use specified fields order 3093 zfs {user,group}space's -i is noop Reviewed by: Garry Mills <gary_mills@fastmail.fm> Reviewed by: Eric Schrock <eric.schrock@delphix.com> Approved by: Richard Lowe <richlowe@richlowe.net> References: illumos/illumos-gate@89f5d17 illumos changeset: 13803:b5e49d71ff0e https://www.illumos.org/issues/1884 https://www.illumos.org/issues/3028 https://www.illumos.org/issues/3048 https://www.illumos.org/issues/3049 https://www.illumos.org/issues/3060 https://www.illumos.org/issues/3061 https://www.illumos.org/issues/3093 Ported-by: Brian Behlendorf <behlendorf1@llnl.gov> Closes openzfs#1194
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There's a missing semicolon in the first hunk of this commit
in config/kernel-bdi.m4. This results in the test always failing.
The effects were noticed when rrdtool, a tool which modifies files
by mmap() and msync(), would have data never get saved to disk
in spite of the files working while the mounted filesystem remains
mounted.