Join GitHub today
GitHub is home to over 31 million developers working together to host and review code, manage projects, and build software together.Sign up
Support accessing .zfs/snapshot via NFS #2797
@yshui Thanks for picking up the issue and helping push it forward. I'd love to get this functionality in place so lets start by sorting out the build failures and make sure all the automated testing passes.
I like the fact that this pull request is broken up in to many logical changes with good comments. It makes the patch review easier. But could you please restructure the patch stack so that it builds on itself. Patches earlier in the stack should add the infrastructure needed by patches later in the stack. This is important because when the buildbot tests the patch it will test every commit in the stack and we want all those tests to pass.
You can see the buildbot results in the details for this pull request.
One more thing to be aware of. The buildbot uses the --enable-debug option to maximize test coverage. This also causes build warnings like the one below to be fatal. You'll need to address this and the style issues which were identified.
2 times, most recently
Oct 17, 2014
referenced this pull request
Nov 24, 2014
@arturpzol No, this has never worked. Although, we expect to have it implemented for the official 0.6.4 tag using this patch stack. One of the very few remaining hold ups is additional testing of this patch stack. If you could try it out and report back that would be a great data point.
@yshui I was just looking this over again to see if we can get it in for 0.6.4 and noticed you have fixsnap2 and fixsnap3 branch. It looks to me like fixsnap3 was the exploratory branch for using