Add missing module_param for zfs_per_txg_dirty_frees_percent #5750
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@dpquigl, thanks for your PR! By analyzing the history of the files in this pull request, we identified @behlendorf, @ahrens and @FransUrbo to be potential reviewers. |
behlendorf
requested changes
Feb 6, 2017
man/man5/zfs-module-parameters.5
Outdated
| @@ -1441,6 +1441,22 @@ Default value: \fB52,428,800\fR. | |||
| .sp | |||
| .ne 2 | |||
| .na | |||
| \fBzfs_per_txg_dirty_frees_percent \fR (int) | |||
There was a problem hiding this comment.
Good catch. I'll fix.
| module_param(zfs_mdcomp_disable, int, 0644); | ||
| MODULE_PARM_DESC(zfs_mdcomp_disable, "Disable meta data compression"); | ||
|
|
||
| module_param(zfs_nopwrite_enabled, int, 0644); | ||
| MODULE_PARM_DESC(zfs_nopwrite_enabled, "Enable NOP writes"); | ||
|
|
||
| module_param(zfs_per_txg_dirty_frees_percent, ulong, 0644); | ||
| MODULE_PARM_DESC(zfs_per_txg_dirty_frees_percent, | ||
| "percentage of dirtied blocks from frees in one TXG"); |
There was a problem hiding this comment.
Missing /* END CSTYLED */.
When the code was added this tunable was not exposed via module params. Also it was not documented. This patch changes the type from a uint32 to a ulong as done with other percentage tunables and also documents it in the zfs-module-parameters man page.
|
Changes made and new branch pushed out. |
behlendorf
approved these changes
Feb 7, 2017
wli5
pushed a commit
to wli5/zfs
that referenced
this pull request
Feb 28, 2017
When the code was added this tunable was not exposed via module params. Also it was not documented. This patch changes the type from a uint32 to a ulong as done with other percentage tunables and also documents it in the zfs-module-parameters man page. Reviewed-by: Brian Behlendorf <behlendorf1@llnl.gov> Signed-off-by: David Quigley <david.quigley@intel.com> Closes openzfs#5750
wli5
pushed a commit
to wli5/zfs
that referenced
this pull request
Feb 28, 2017
When the code was added this tunable was not exposed via module params. Also it was not documented. This patch changes the type from a uint32 to a ulong as done with other percentage tunables and also documents it in the zfs-module-parameters man page. Reviewed-by: Brian Behlendorf <behlendorf1@llnl.gov> Signed-off-by: David Quigley <david.quigley@intel.com> Closes openzfs#5750
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
When the code was added this tunable was not exposed via module params. Also it
was not documented. This patch changes the type from a uint32 to a ulong as
done with other percentage tunables and also documents it in the
zfs-module-parameters man page.