Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

(Fixes #7287) modprobe zfs during dracut mount #7322

Merged
merged 1 commit into from Mar 22, 2018

Conversation

Projects
5 participants
@kpande
Copy link
Contributor

commented Mar 21, 2018

modprobe zfs during dracut

Signed-off-by: Kash Pande kash@tripleback.net

Description

Motivation and Context

How Has This Been Tested?

Types of changes

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Performance enhancement (non-breaking change which improves efficiency)
  • Code cleanup (non-breaking change which makes code smaller or more readable)
  • Breaking change (fix or feature that would cause existing functionality to change)
  • Documentation (a change to man pages or other documentation)

Checklist:

  • My code follows the ZFS on Linux code style requirements.
  • I have updated the documentation accordingly.
  • I have read the CONTRIBUTING document.
  • I have added tests to cover my changes.
  • All new and existing tests passed.
  • All commit messages are properly formatted and contain Signed-off-by.
  • Change has been approved by a ZFS on Linux member.
Kash Pande
(Fixes #7287) modprobe zfs during dracut mount
Signed-off-by: Kash Pande <kash@tripleback.net>
@codecov

This comment has been minimized.

Copy link

commented Mar 21, 2018

Codecov Report

Merging #7322 into master will decrease coverage by 0.1%.
The diff coverage is n/a.

Impacted file tree graph

@@            Coverage Diff             @@
##           master    #7322      +/-   ##
==========================================
- Coverage   76.48%   76.37%   -0.11%     
==========================================
  Files         329      329              
  Lines      104193   104193              
==========================================
- Hits        79688    79578     -110     
- Misses      24505    24615     +110
Flag Coverage Δ
#kernel 76.32% <ø> (-0.12%) ⬇️
#user 65.65% <ø> (-0.16%) ⬇️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 089fbf3...c5af8b4. Read the comment docs.

@behlendorf
Copy link
Member

left a comment

Thanks for the fix!

@kpande

This comment has been minimized.

Copy link
Contributor Author

commented Mar 21, 2018

yeah it works here for me but i don't build built-in. do you know of anyone who does that can test?

@prometheanfire
Copy link
Contributor

left a comment

I don't see a problem with this

modprobe zfs
echo $?
0

That's on a builtin system

@behlendorf behlendorf added this to TODO in 0.7.9 Mar 21, 2018

@behlendorf behlendorf merged commit 05747ec into zfsonlinux:master Mar 22, 2018

26 checks passed

buildbot/Amazon 2 x86_64 (BUILD) Build done.
Details
buildbot/Amazon 2 x86_64 Release (TEST) Build done.
Details
buildbot/CentOS 6 x86_64 (BUILD) Build done.
Details
buildbot/CentOS 6 x86_64 (TEST) Build done.
Details
buildbot/CentOS 7 x86_64 (BUILD) Build done.
Details
buildbot/CentOS 7 x86_64 (TEST) Build done.
Details
buildbot/CentOS 7 x86_64 Mainline (TEST) Build done.
Details
buildbot/CentOS 7 x86_64 Release (BUILD) Build done.
Details
buildbot/Debian 8 arm (BUILD) Build done.
Details
buildbot/Debian 8 ppc (BUILD) Build done.
Details
buildbot/Debian 8 ppc64 (BUILD) Build done.
Details
buildbot/Debian 8 x86_64 (BUILD) Build done.
Details
buildbot/Fedora 27 x86_64 (BUILD) Build done.
Details
buildbot/Fedora 27 x86_64 (TEST) Build done.
Details
buildbot/Fedora Rawhide x86_64 (TEST) Build done.
Details
buildbot/Kernel.org Built-in x86_64 (BUILD) Build done.
Details
buildbot/Ubuntu 14.04 x86_64 (BUILD) Build done.
Details
buildbot/Ubuntu 16.04 aarch64 (BUILD) Build done.
Details
buildbot/Ubuntu 16.04 i386 (BUILD) Build done.
Details
buildbot/Ubuntu 16.04 x86_64 (BUILD) Build done.
Details
buildbot/Ubuntu 16.04 x86_64 (TEST) Build done.
Details
buildbot/Ubuntu 17.04 x86_64 Coverage (TEST) Build done.
Details
buildbot/Ubuntu 17.10 x86_64 (STYLE) Build done.
Details
buildbot/Ubuntu 17.10 x86_64 (TEST) Build done.
Details
codecov/patch Coverage not affected when comparing 089fbf3...c5af8b4
Details
codecov/project 76.37% (-0.11%) compared to 089fbf3
Details

@tonyhutter tonyhutter moved this from TODO to In progress in 0.7.9 Apr 12, 2018

tonyhutter added a commit to tonyhutter/zfs that referenced this pull request Apr 16, 2018

modprobe zfs during dracut mount
Resolves importing root pool during boot in dracut.  This case was
inadvertently broken with the module autoloading change in zfsonlinux#7287.

Reviewed-by: Matthew Thode <prometheanfire@gentoo.org>
Reviewed-by: George Melikov <mail@gmelikov.ru>
Reviewed-by: Brian Behlendorf <behlendorf1@llnl.gov>
Reviewed-by: Giuseppe Di Natale <dinatale2@llnl.gov>
Signed-off-by: Kash Pande <kash@tripleback.net>
Closes zfsonlinux#7322

tonyhutter added a commit to tonyhutter/zfs that referenced this pull request May 4, 2018

modprobe zfs during dracut mount
Resolves importing root pool during boot in dracut.  This case was
inadvertently broken with the module autoloading change in zfsonlinux#7287.

Reviewed-by: Matthew Thode <prometheanfire@gentoo.org>
Reviewed-by: George Melikov <mail@gmelikov.ru>
Reviewed-by: Brian Behlendorf <behlendorf1@llnl.gov>
Reviewed-by: Giuseppe Di Natale <dinatale2@llnl.gov>
Signed-off-by: Kash Pande <kash@tripleback.net>
Closes zfsonlinux#7322

tonyhutter added a commit that referenced this pull request May 10, 2018

modprobe zfs during dracut mount
Resolves importing root pool during boot in dracut.  This case was
inadvertently broken with the module autoloading change in #7287.

Reviewed-by: Matthew Thode <prometheanfire@gentoo.org>
Reviewed-by: George Melikov <mail@gmelikov.ru>
Reviewed-by: Brian Behlendorf <behlendorf1@llnl.gov>
Reviewed-by: Giuseppe Di Natale <dinatale2@llnl.gov>
Signed-off-by: Kash Pande <kash@tripleback.net>
Closes #7322
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
You can’t perform that action at this time.