Fix for current_kernel_time in 4.20 on 0.7.x #8227
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
While openzfs/spl@cd1b28e fixed the 4.20 current_kernel_time issues in spl as per openzfs#8074 in .07.x, current_kernel_time is still being used inside zpios-ctl.h in 0.7.x. I believe this may fix this issue in 0.7.x to allow it to compile successfully for kernel 4.2.0.
behlendorf
approved these changes
Dec 26, 2018
behlendorf
added
Status: Accepted
|
Hey there, I just stumbled upon this after upgrades to my Arch Linux install with zfs 0.7.12 to the 4.20 kernel. Just adding a datapoint: This patch works flawlessly 👍 Would be grateful if this could get merged and tagged as soon as possible, as 4.20 is the kernel that is distributed with Arch right now and currently zfs breaks DKMS builds without this patch. |
|
@tonyhutter If you would consider adding this to https://github.com/zfsonlinux/zfs/projects/21 ? |
gyakovlev
pushed a commit
to gyakovlev/zfs
that referenced
this pull request
Jan 9, 2019
just a copy of openzfs#8227 with builder configuration, want to test the patch. Requires-spl: spl-0.7-release Signed-off-by: gyakovlev@gentoo.org
gyakovlev
pushed a commit
to gyakovlev/zfs
that referenced
this pull request
Jan 9, 2019
just a copy of openzfs#8227 with builder configuration, want to test the patch. Requires-spl: spl-0.7-release Requires-builders: test unstable Signed-off-by: gyakovlev@gentoo.org
12 tasks
gyakovlev
added a commit
to gyakovlev/zfs
that referenced
this pull request
Jan 9, 2019
just a copy of openzfs#8227 with builder configuration, want to test the patch. Requires-spl: spl-0.7-release Requires-builders: test unstable Signed-off-by: gyakovlev@gentoo.org
gyakovlev
added a commit
to gyakovlev/zfs
that referenced
this pull request
Jan 9, 2019
just a copy of openzfs#8227 with builder configuration, want to test the patch. Requires-spl: spl-0.7-release Requires-builders: test unstable Signed-off-by: Georgy Yakovlev <gyakovlev@gentoo.org>
|
Closing, this fix has been included in the openzfs/spl#713 patch set. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
While openzfs/spl@cd1b28e fixed the 4.20 current_kernel_time issues in the 0.7.x spl tree as per #8074 in 0.7.x, current_kernel_time is still being used inside zpios-ctl.h inside the 0.7.x zfs tree.
I believe this patch may fix this issue in 0.7.x to allow it to compile successfully for linux kernel 4.20.
Apologies if the coding style is inappropriate. The compiled module once so modified does work on my system, but I have not run tests on this.
current_kernel_time needs to be updated for linux kernel 4.20 compatibility. While the 0.7.x spl's sys/include/time.h file was updated, in the 0.7.x zfs tree zpios-ctl.h also uses current_kernel_time.
Motivation and Context
Fixed compile for 4.20 on 0.7.x on my ubuntu system.
The modifications as as per the issue referenced here: #8074 and also as applied in this commit: openzfs/spl@cd1b28e
Description
How Has This Been Tested?
Types of changes
Checklist:
(Note that this is for the 0.7.x branch and NOT for master.)
Signed-off-by.