Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Further improve 'zpool labelclear' command #8548

Open
wants to merge 1 commit into
base: master
from

Conversation

Projects
None yet
2 participants
@martymac
Copy link

commented Mar 29, 2019

Hello,

That patch follows : #8500 to further improve the labelclear command.

It is an updated version of my my previous patch for OpenZFS :

openzfs/openzfs#424

Description

Basically, the patch adds the following :

  • ability to clear a specific label (options -b, -e and -i)
  • label invalidation using a single-byte modification (use -w to zeroe the label as before)
  • option -ff to force invalidation even for invalid labels

How Has This Been Tested?

The patch has been tested on Debian 9 with a file-backed zpool.

Types of changes

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Performance enhancement (non-breaking change which improves efficiency)
  • Code cleanup (non-breaking change which makes code smaller or more readable)
  • Breaking change (fix or feature that would cause existing functionality to change)
  • Documentation (a change to man pages or other documentation)

Checklist:

Further improve 'zpool labelclear' command
That patch follows:
  #8500
and is a port to ZoL of:
  openzfs/openzfs#424

It adds the following:
  - ability to clear a specific label (options -b, -e and -i)
  - label invalidation using a single-byte modification (wipe with option -w)
  - option -ff to force invalidation even for invalid labels

OpenZFS-issue: https://www.illumos.org/issues/7584
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
You can’t perform that action at this time.