Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

We should document CSP requirements #107

Closed
arp242 opened this issue Jan 14, 2020 · 2 comments · Fixed by #122
Closed

We should document CSP requirements #107

arp242 opened this issue Jan 14, 2020 · 2 comments · Fixed by #122
Labels
Milestone

Comments

@arp242
Copy link
Collaborator

@arp242 arp242 commented Jan 14, 2020

No description provided.

@arp242 arp242 added this to the Version 1.1 milestone Jan 14, 2020
@arp242 arp242 added the enhancement label Jan 14, 2020
@ljoonal

This comment has been minimized.

Copy link

@ljoonal ljoonal commented Jan 14, 2020

As I'm currently having to setup my CSP rules for nginx, I might as well copy them somewhere and write a bit about them while I'm at it. Where'd you want it documented at? :)

arp242 added a commit that referenced this issue Jan 16, 2020
- There way no reason to build a new script tag, we can just use a
  script tag directly. I don't know why I did it like that; probably
  just copy/paste from other sources who copy/pasted it themselves?

- Document CSP requirements and use data-goatcounter attribute so people
  don't have to set window.counter.

- Add CORS header so people can load it from XHR/fetch without count.js

- Document some more advanced usages.

Fixes #107, #114
@arp242

This comment has been minimized.

Copy link
Collaborator Author

@arp242 arp242 commented Jan 16, 2020

Thanks @ljoonal; it's not too hard, but right now you need unsafe-inline for the default case, which isn't great 😅 Want to fix that as well. I'm working on it in #122.

@arp242 arp242 closed this Jan 16, 2020
arp242 added a commit that referenced this issue Jan 18, 2020
- There way no reason to build a new script tag, we can just use a
  script tag directly. I don't know why I did it like that; probably
  just copy/paste from other sources who copy/pasted it themselves?

- Document CSP requirements and use data-goatcounter attribute so people
  don't have to set window.counter.

- Add CORS header so people can load it from XHR/fetch without count.js

- Document some more advanced usages.

Fixes #107, #114
arp242 added a commit that referenced this issue Jan 20, 2020
- There way no reason to build a new script tag, we can just use a
  script tag directly. I don't know why I did it like that; probably
  just copy/paste from other sources who copy/pasted it themselves?

- Document CSP requirements and use data-goatcounter attribute so people
  don't have to set window.counter.

- Add CORS header so people can load it from XHR/fetch without count.js

- Document some more advanced usages.

Fixes #107, #114
arp242 added a commit that referenced this issue Jan 24, 2020
- There way no reason to build a new script tag, we can just use a
  script tag directly. I don't know why I did it like that; probably
  just copy/paste from other sources who copy/pasted it themselves?

- Document CSP requirements and use data-goatcounter attribute so people
  don't have to set window.counter.

- Add CORS header so people can load it from XHR/fetch without count.js

- Document some more advanced usages.

Fixes #107, #114
arp242 added a commit that referenced this issue Jan 26, 2020
- There way no reason to build a new script tag, we can just use a
  script tag directly. I don't know why I did it like that; probably
  just copy/paste from other sources who copy/pasted it themselves?

- Document CSP requirements and use data-goatcounter attribute so people
  don't have to set window.counter.

- Add CORS header so people can load it from XHR/fetch without count.js

- Document some more advanced usages.

Fixes #107, #114
arp242 added a commit that referenced this issue Jan 26, 2020
* Improve the site code

- There way no reason to build a new script tag, we can just use a
  script tag directly. I don't know why I did it like that; probably
  just copy/paste from other sources who copy/pasted it themselves?

- Document CSP requirements and use data-goatcounter attribute so people
  don't have to set window.counter.

- Add CORS header so people can load it from XHR/fetch without count.js

- Document some more advanced usages.

Fixes #107, #114

* Some minor fixes

* Finish up
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
2 participants
You can’t perform that action at this time.