Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Improve the site code #122

Merged
merged 3 commits into from Jan 26, 2020
Merged

Improve the site code #122

merged 3 commits into from Jan 26, 2020

Conversation

@arp242
Copy link
Collaborator

arp242 commented Jan 16, 2020

  • There is no reason to build a new script tag in JS, we can just use a
    script tag directly. I don't know why I did it like that; probably
    just copy/paste from other sources who copy/pasted it themselves?

  • Document CSP requirements and use data-goatcounter attribute so people
    don't have to set window.counter.

  • Add CORS header so people can load it from XHR/fetch without count.js

  • Document some more advanced usages.

Fixes #107, #114

@arp242 arp242 added the wip label Jan 16, 2020
This was referenced Jan 16, 2020
@arp242 arp242 force-pushed the script branch 3 times, most recently from 474012b to 706cd24 Jan 18, 2020
arp242 added 2 commits Jan 16, 2020
- There way no reason to build a new script tag, we can just use a
  script tag directly. I don't know why I did it like that; probably
  just copy/paste from other sources who copy/pasted it themselves?

- Document CSP requirements and use data-goatcounter attribute so people
  don't have to set window.counter.

- Add CORS header so people can load it from XHR/fetch without count.js

- Document some more advanced usages.

Fixes #107, #114
@arp242 arp242 force-pushed the script branch from 706cd24 to f158dc7 Jan 26, 2020
@arp242 arp242 force-pushed the script branch from 4103780 to dff1b5b Jan 26, 2020
@arp242 arp242 removed the wip label Jan 26, 2020
@arp242 arp242 merged commit b45deb4 into master Jan 26, 2020
8 checks passed
8 checks passed
Pages changed All files already uploaded
Details
Redirect rules No redirect rules processed
Details
Header rules 2 header rules processed
Details
Mixed content No mixed content detected
Details
codecov/project 47.93% (+0.02%) compared to 52000ae
Details
continuous-integration/travis-ci/pr The Travis CI build passed
Details
continuous-integration/travis-ci/push The Travis CI build passed
Details
deploy/netlify Deploy preview ready!
Details
@arp242 arp242 deleted the script branch Jan 26, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Linked issues

Successfully merging this pull request may close these issues.

1 participant
You can’t perform that action at this time.