Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Use a size_stats table #203

Merged
merged 3 commits into from Mar 16, 2020
Merged

Use a size_stats table #203

merged 3 commits into from Mar 16, 2020

Conversation

@arp242
Copy link
Collaborator

arp242 commented Mar 15, 2020

Don't know why I didn't use a table for this one; it's a massive performance
win.

Before when selecting a month:

backend  1219ms  pages.List
backend     3ms  browsers.List
backend   554ms  sizeStat.ListSizes
backend     6ms  locStat.List
backend     2ms  topRefs.List
backend    13ms  zhttp.Template

After:

backend  1020ms  pages.List
backend     5ms  browsers.List
backend     2ms  sizeStat.ListSizes
backend     5ms  locStat.List
backend     5ms  topRefs.List
backend    33ms  zhttp.Template
@arp242 arp242 force-pushed the size_stats branch 2 times, most recently from 274d117 to 280c1ca Mar 15, 2020
Don't know why I didn't use a table for this one; it's a massive performance
win.

Before when selecting a month:

	backend  1219ms  pages.List
	backend     3ms  browsers.List
	backend   554ms  sizeStat.ListSizes
	backend     6ms  locStat.List
	backend     2ms  topRefs.List
	backend    13ms  zhttp.Template

After:

	backend  1020ms  pages.List
	backend     5ms  browsers.List
	backend     2ms  sizeStat.ListSizes
	backend     5ms  locStat.List
	backend     5ms  topRefs.List
	backend    33ms  zhttp.Template
@arp242 arp242 force-pushed the size_stats branch from 280c1ca to b74377e Mar 16, 2020
arp242 added 2 commits Mar 16, 2020
I've noticed a few times where builds fail because of invalid cache
lately.
@arp242 arp242 merged commit a713825 into master Mar 16, 2020
4 of 7 checks passed
4 of 7 checks passed
Header rules
Details
Mixed content
Details
Redirect rules
Details
Pages changed All files already uploaded
Details
continuous-integration/travis-ci/pr The Travis CI build passed
Details
continuous-integration/travis-ci/push The Travis CI build passed
Details
deploy/netlify Deploy preview ready!
Details
@arp242 arp242 deleted the size_stats branch Mar 16, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Linked issues

Successfully merging this pull request may close these issues.

None yet

1 participant
You can’t perform that action at this time.