Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

插件生成器和插件列表的相关破坏性更新 #321

Merged
merged 16 commits into from
Mar 1, 2023

Conversation

crazywhalecc
Copy link
Member

@crazywhalecc crazywhalecc commented Feb 20, 2023

  • 插件列表命令
  • 插件生成器重构:创建目录要变成但级目录
  • 插件生成器重构:检测并兼容旧版插件(zmplugin.json)
  • 插件生成器重构:帮助生成插件的 Git 仓库、GitHub Action、.gitignore 等文件

@crazywhalecc crazywhalecc added the enhancement 新功能请求 label Feb 20, 2023
@crazywhalecc crazywhalecc self-assigned this Feb 20, 2023
@crazywhalecc crazywhalecc marked this pull request as draft February 20, 2023 15:46
@sunxyw
Copy link
Member

sunxyw commented Feb 22, 2023

把安装命令的具体流程分到不同的类会不会比较好。
比如弄 GitCloneStrategy, VCSRemoteStrategy, ComposerPackageStrategy 之类,然后用责任链或者什么串起来?以后加新方式或者维护也方便写吧,比起全部写在命令里。

@crazywhalecc
Copy link
Member Author

把安装命令的具体流程分到不同的类会不会比较好。 比如弄 GitCloneStrategy, VCSRemoteStrategy, ComposerPackageStrategy 之类,然后用责任链或者什么串起来?以后加新方式或者维护也方便写吧,比起全部写在命令里。

(摊手)这应该就是个分文件的问题,对开发者和用户应该是无感知的更新,后续可以有时间优化(或者你懂的,某人来写)。

@crazywhalecc crazywhalecc marked this pull request as ready for review February 28, 2023 15:15
@crazywhalecc crazywhalecc requested a review from sunxyw February 28, 2023 15:16
@crazywhalecc
Copy link
Member Author

TODO List 提到的最后一个 Actions、gitignore 等的更新需要配套的 GH Action 和 gitignore 文件写好,暂时不考虑在此 PR 内。

@crazywhalecc crazywhalecc merged commit 3d79202 into main Mar 1, 2023
@crazywhalecc crazywhalecc deleted the add-disable-plugin-func branch March 1, 2023 08:07
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement 新功能请求
Projects
Status: Done
Development

Successfully merging this pull request may close these issues.

2 participants