Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

重构框架核心 #322

Merged
merged 6 commits into from
Mar 9, 2023
Merged

重构框架核心 #322

merged 6 commits into from
Mar 9, 2023

Conversation

sunxyw
Copy link
Member

@sunxyw sunxyw commented Feb 24, 2023

  • refactor framework kernel
  • fix tests
  • fix container not loading config
  • fix properties not initialized

@sunxyw sunxyw added enhancement 新功能请求 improvement 对于现有代码或逻辑的改进 labels Feb 24, 2023
@sunxyw sunxyw requested a review from crazywhalecc February 24, 2023 15:24
Copy link
Member

@crazywhalecc crazywhalecc left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

提案需重新商讨。

@sunxyw sunxyw force-pushed the refactor-framework-kernel branch from 87a234c to 772288b Compare March 7, 2023 15:08
@sunxyw sunxyw requested a review from crazywhalecc March 7, 2023 16:29
@crazywhalecc
Copy link
Member

Test 没过,需要看下。还有那个 Has 什么的接口,感觉它应该是个 Trait 才对,或者改个名?另外 src/ZM 下尽量不要堆太多东西。

@sunxyw
Copy link
Member Author

sunxyw commented Mar 9, 2023

blocked by zhamao-robot/zhamao-logger#7

@sunxyw sunxyw merged commit 0184d37 into main Mar 9, 2023
@sunxyw sunxyw deleted the refactor-framework-kernel branch March 9, 2023 15:43
@crazywhalecc crazywhalecc linked an issue Mar 11, 2023 that may be closed by this pull request
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement 新功能请求 improvement 对于现有代码或逻辑的改进
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3.1.0 版本无法使用命令行参数,例如 --driver=swoole
2 participants