重构框架核心#322
Merged
Merged
Conversation
sunxyw
commented
Feb 24, 2023
sunxyw
commented
Member
- refactor framework kernel
- fix tests
- fix container not loading config
- fix properties not initialized
sunxyw
force-pushed
the
refactor-framework-kernel
branch
from
March 7, 2023 15:08
87a234c to
772288b
Compare
crazywhalecc
approved these changes
Mar 8, 2023
Member
|
Test 没过，需要看下。还有那个 Has 什么的接口，感觉它应该是个 Trait 才对，或者改个名？另外 src/ZM 下尽量不要堆太多东西。 |
Member
Author
|
blocked by zhamao-robot/zhamao-logger#7 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.