From 8554f98b5363a459f248fcdb00d2fd0890ed461f Mon Sep 17 00:00:00 2001 From: =?UTF-8?q?=CA=88=E1=B5=83=E1=B5=A2?= Date: Fri, 11 Sep 2020 09:54:10 -0700 Subject: [PATCH] fix: update lineMulti when queryData changes (#782) --- .../legacy-preset-chart-nvd3/src/LineMulti/LineMulti.jsx | 5 +++-- 1 file changed, 3 insertions(+), 2 deletions(-) diff --git a/superset-frontend/temporary_superset_ui/superset-ui/plugins/legacy-preset-chart-nvd3/src/LineMulti/LineMulti.jsx b/superset-frontend/temporary_superset_ui/superset-ui/plugins/legacy-preset-chart-nvd3/src/LineMulti/LineMulti.jsx index 6bb0d67097c7..ccbddf366a4a 100644 --- a/superset-frontend/temporary_superset_ui/superset-ui/plugins/legacy-preset-chart-nvd3/src/LineMulti/LineMulti.jsx +++ b/superset-frontend/temporary_superset_ui/superset-ui/plugins/legacy-preset-chart-nvd3/src/LineMulti/LineMulti.jsx @@ -68,11 +68,12 @@ class LineMulti extends React.Component { this.loadData(this.props); } - shouldComponentUpdate(nextProps) { + shouldComponentUpdate(nextProps, nextState) { const { rawFormData } = this.props; const { rawFormData: nextRawFormData } = nextProps; const { queryData } = this.state; - if (!queryData || !isEqual(rawFormData, nextRawFormData)) { + const { queryData: nextQueryData } = nextState; + if (!isEqual(queryData, nextQueryData) || !isEqual(rawFormData, nextRawFormData)) { return true; }