From ede2e92d97f0eee8e23fc7fd4a0567d1e2b49029 Mon Sep 17 00:00:00 2001 From: Krist Wongsuphasawat Date: Fri, 26 Apr 2019 13:25:51 -0700 Subject: [PATCH] fix: lazily create metadata (#74) --- .../src/Line/createMetadata.ts | 12 ++++++++++++ .../superset-ui-preset-chart-xy/src/Line/index.ts | 4 ++-- .../src/Line/legacy/index.ts | 4 ++-- .../src/Line/legacy/metadata.ts | 6 ------ .../superset-ui-preset-chart-xy/src/Line/metadata.ts | 11 ----------- 5 files changed, 16 insertions(+), 21 deletions(-) create mode 100644 superset-frontend/temporary_superset_ui/superset-ui/plugins/superset-ui-plugins/packages/superset-ui-preset-chart-xy/src/Line/createMetadata.ts delete mode 100644 superset-frontend/temporary_superset_ui/superset-ui/plugins/superset-ui-plugins/packages/superset-ui-preset-chart-xy/src/Line/legacy/metadata.ts delete mode 100644 superset-frontend/temporary_superset_ui/superset-ui/plugins/superset-ui-plugins/packages/superset-ui-preset-chart-xy/src/Line/metadata.ts diff --git a/superset-frontend/temporary_superset_ui/superset-ui/plugins/superset-ui-plugins/packages/superset-ui-preset-chart-xy/src/Line/createMetadata.ts b/superset-frontend/temporary_superset_ui/superset-ui/plugins/superset-ui-plugins/packages/superset-ui-preset-chart-xy/src/Line/createMetadata.ts new file mode 100644 index 000000000000..6eadf746eb52 --- /dev/null +++ b/superset-frontend/temporary_superset_ui/superset-ui/plugins/superset-ui-plugins/packages/superset-ui-preset-chart-xy/src/Line/createMetadata.ts @@ -0,0 +1,12 @@ +import { t } from '@superset-ui/translation'; +import { ChartMetadata } from '@superset-ui/chart'; +import thumbnail from './images/thumbnail.png'; + +export default function createMetadata(useLegacyApi = false) { + return new ChartMetadata({ + description: '', + name: t('Line Chart'), + thumbnail, + useLegacyApi, + }); +} diff --git a/superset-frontend/temporary_superset_ui/superset-ui/plugins/superset-ui-plugins/packages/superset-ui-preset-chart-xy/src/Line/index.ts b/superset-frontend/temporary_superset_ui/superset-ui/plugins/superset-ui-plugins/packages/superset-ui-preset-chart-xy/src/Line/index.ts index b5cad765d9ac..9a9681d8fdb0 100644 --- a/superset-frontend/temporary_superset_ui/superset-ui/plugins/superset-ui-plugins/packages/superset-ui-preset-chart-xy/src/Line/index.ts +++ b/superset-frontend/temporary_superset_ui/superset-ui/plugins/superset-ui-plugins/packages/superset-ui-preset-chart-xy/src/Line/index.ts @@ -1,6 +1,6 @@ import { ChartPlugin } from '@superset-ui/chart'; -import metadata from './metadata'; import transformProps from './transformProps'; +import createMetadata from './createMetadata'; import buildQuery from './buildQuery'; import ChartFormData from './ChartFormData'; @@ -9,7 +9,7 @@ export default class LineChartPlugin extends ChartPlugin { super({ buildQuery, loadChart: () => import('./Line'), - metadata, + metadata: createMetadata(), transformProps, }); } diff --git a/superset-frontend/temporary_superset_ui/superset-ui/plugins/superset-ui-plugins/packages/superset-ui-preset-chart-xy/src/Line/legacy/index.ts b/superset-frontend/temporary_superset_ui/superset-ui/plugins/superset-ui-plugins/packages/superset-ui-preset-chart-xy/src/Line/legacy/index.ts index 1cd56c6be682..2fe4dafdbcbd 100644 --- a/superset-frontend/temporary_superset_ui/superset-ui/plugins/superset-ui-plugins/packages/superset-ui-preset-chart-xy/src/Line/legacy/index.ts +++ b/superset-frontend/temporary_superset_ui/superset-ui/plugins/superset-ui-plugins/packages/superset-ui-preset-chart-xy/src/Line/legacy/index.ts @@ -1,12 +1,12 @@ import { ChartPlugin } from '@superset-ui/chart'; -import metadata from './metadata'; import transformProps from './transformProps'; +import createMetadata from '../createMetadata'; export default class LineChartPlugin extends ChartPlugin { constructor() { super({ loadChart: () => import('../Line'), - metadata, + metadata: createMetadata(true), transformProps, }); } diff --git a/superset-frontend/temporary_superset_ui/superset-ui/plugins/superset-ui-plugins/packages/superset-ui-preset-chart-xy/src/Line/legacy/metadata.ts b/superset-frontend/temporary_superset_ui/superset-ui/plugins/superset-ui-plugins/packages/superset-ui-preset-chart-xy/src/Line/legacy/metadata.ts deleted file mode 100644 index 2f532e6a2380..000000000000 --- a/superset-frontend/temporary_superset_ui/superset-ui/plugins/superset-ui-plugins/packages/superset-ui-preset-chart-xy/src/Line/legacy/metadata.ts +++ /dev/null @@ -1,6 +0,0 @@ -import metadata from '../metadata'; - -const legacyMetadata = metadata.clone(); -legacyMetadata.useLegacyApi = true; - -export default legacyMetadata; diff --git a/superset-frontend/temporary_superset_ui/superset-ui/plugins/superset-ui-plugins/packages/superset-ui-preset-chart-xy/src/Line/metadata.ts b/superset-frontend/temporary_superset_ui/superset-ui/plugins/superset-ui-plugins/packages/superset-ui-preset-chart-xy/src/Line/metadata.ts deleted file mode 100644 index 651c7709cc31..000000000000 --- a/superset-frontend/temporary_superset_ui/superset-ui/plugins/superset-ui-plugins/packages/superset-ui-preset-chart-xy/src/Line/metadata.ts +++ /dev/null @@ -1,11 +0,0 @@ -import { t } from '@superset-ui/translation'; -import { ChartMetadata } from '@superset-ui/chart'; -import thumbnail from './images/thumbnail.png'; - -const metadata = new ChartMetadata({ - description: '', - name: t('Line Chart'), - thumbnail, -}); - -export default metadata;