Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Make the error message show what kind of string is bad. #103

Merged
merged 5 commits into from Aug 23, 2021

Conversation

Julian
Copy link
Contributor

@Julian Julian commented Aug 20, 2021

Closes: #102

Copy link
Collaborator

@twolfson twolfson left a comment

Ehh, I have a lot of nitpicks around this implementation =/ Will just commandeer rather than try to force mindreading =/ Will update + land by Fri Aug 27

  • Would prefer messages be written out as-is inside the INLINE and MULTILINE configs (good for i18n flexibility)
  • New messages are very verbose, worry about being too noisy for console feedback
  • Disliking how tests are using variables in assertion expectationss (should almost always be avoided as it can lead to more levels of indirection which makes testing unclear)

@Julian
Copy link
Contributor Author

Julian commented Aug 20, 2021

Sure, go for it, thanks.

@twolfson
Copy link
Collaborator

twolfson commented Aug 23, 2021

Looking into this now. As a heads up, this branch is currently failing ./test.sh. I'll look into why as part of the resolution

@twolfson
Copy link
Collaborator

twolfson commented Aug 23, 2021

That was kind of tedious but it's all back to functional now. Landing PR

@twolfson twolfson merged commit 07f161c into zheller:master Aug 23, 2021
@twolfson
Copy link
Collaborator

twolfson commented Aug 23, 2021

This has been released in flake8-quotes@3.3.0. Thanks for your work!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Friendlier error message
2 participants