Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update add_options for flake8 6.0 #111

Merged
merged 1 commit into from
Dec 9, 2022

Conversation

alexfikl
Copy link
Contributor

This seems to make flake8-quotes work with flake8 6 for me, i.e. tests pass and projects lint without crashes. For details
https://flake8.pycqa.org/en/latest/release-notes/6.0.0.html#backwards-incompatible-changes

Fixes #110

Copy link

@GareeTest GareeTest left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

kalikiana added a commit to os-autoinst/openqa_review that referenced this pull request Dec 2, 2022
kalikiana added a commit to os-autoinst/openqa_review that referenced this pull request Dec 2, 2022
kalikiana added a commit to os-autoinst/openqa_review that referenced this pull request Dec 2, 2022
kalikiana added a commit to os-autoinst/openqa_review that referenced this pull request Dec 2, 2022
ScottMcCormack referenced this pull request in arthurdejong/webchat Dec 4, 2022
The new 6.0.0 contains a number of backwards incompatible changes
for which plugins need to be updated and configuration needs to be
updated.

Sadly the maintainer no longer accepts contributions or discussion
See PyCQA/flake8#1760
@DanielSchiavini
Copy link

When is this expected to be released?

@gdalmau
Copy link

gdalmau commented Dec 6, 2022

@zheller @twolfson Can you take a look at this PR?

Copy link
Collaborator

@JoeHitchen JoeHitchen left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me - Tested with Flake8 v5 & v6 by running the unittests and by invoking the cli with various options to check they work as expected.

@bra-fsn
Copy link

bra-fsn commented Dec 9, 2022

When is this expected to be released?

The number of reviewers seems to be too low ATM, it might need more approvals?

@zheller zheller merged commit 5e58744 into zheller:master Dec 9, 2022
@jakealstad
Copy link

ty for the merge

@alexfikl alexfikl deleted the port-flake8-v6.0 branch December 9, 2022 19:51
@vmarkovtsev
Copy link

@zheller would you mind making a new release please 🙏

@evrial
Copy link

evrial commented Dec 15, 2022

@zheller make a release

@dopry
Copy link

dopry commented Dec 15, 2022

@evrial demanding things from an OSS contributor like a petulant child is uncalled for.

@evrial
Copy link

evrial commented Dec 16, 2022

@dopry fair enough. what options do we have? fork and call flake8-quotes2 ?

@Avasam
Copy link

Avasam commented Dec 16, 2022

@dopry fair enough. what options do we have? fork and call flake8-quotes2 ?

pip install git+https://github.com/zheller/flake8-quotes.git#egg=flake8-quotes

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Incompatibility with flake8 v6