Skip to content

Tom Zhou zhouqt

Organizations

Autotest
zhouqt commented on pull request autotest/tp-qemu#98
Tom Zhou

packet_sizes = params.get("packet_size").split() Can't work here?

zhouqt commented on pull request autotest/virt-test#1616
Tom Zhou

+1 Well, looks this module doesn't have unittest script.

zhouqt commented on pull request autotest/virt-test#1608
Tom Zhou

Hey @liyangfnst Looks this function is used to remove qemu geust agent channel. I remember there is another agent in libvirt level which is called…

zhouqt commented on pull request autotest/virt-test#1618
Tom Zhou

+1 for this patch.

zhouqt commented on pull request autotest/virt-test#1573
Tom Zhou

+1 because the patches look workable and pass Travis.

zhouqt commented on pull request autotest/virt-test#1590
Tom Zhou

Looks OK now. +1

zhouqt commented on pull request autotest/virt-test#1593
Tom Zhou

Hey @xiangmin, I'd ask why you need to put these functions global? IMO, you break the cohesion [1] of a class, I even prefer copying these function…

zhouqt commented on pull request autotest/virt-test#1573
Tom Zhou

Hey @ypu, I'd say this PR should work. But because the env_process module has bad smell for quite a long time, I think this PR couldn't make it worse.

zhouqt commented on pull request autotest/virt-test#1603
Tom Zhou

Hey @yangdongsheng, Be careful for this movement. I remember there are some default value in the subtests.cfg, which will be overridden in the gues…

zhouqt commented on pull request autotest/virt-test#1577
Tom Zhou

+1

zhouqt commented on pull request autotest/virt-test#1590
Tom Zhou

Same as above.

zhouqt commented on pull request autotest/virt-test#1590
Tom Zhou

I guess you're super busy, but this if statement is out of the 'for' loop, do you think you can get the correct vm name?

zhouqt commented on pull request autotest/virt-test#1587
Tom Zhou

+1 for this PR

zhouqt commented on pull request autotest/virt-test#1592
Tom Zhou

+1 for this patch.

zhouqt commented on pull request autotest/virt-test#1592
Tom Zhou

+1 for this patch.

zhouqt commented on pull request autotest/virt-test#1592
Tom Zhou

+1 for this patch.

zhouqt commented on pull request autotest/virt-test#1590
Tom Zhou

No, I can see it should work well here, I'm just curious. "Coding style" is a good reason. +1 for this patch.

zhouqt commented on pull request autotest/virt-test#1577
Tom Zhou

Hey @ypu, I'm glad to see that the multiqueue functionality is under control finally. But for this "run_invalid_cmd" parameter, I'd suggest that we…

zhouqt commented on pull request autotest/virt-test#1590
Tom Zhou

This line of log is out of the 'for vm...' loop's scope, is it indeed needed when you have logs in the 'for' loop?

zhouqt commented on pull request autotest/virt-test#1590
Tom Zhou

OK, this line of log is reasonable. it shows how many times the thread fails to get the register info. But I still would suggest that it's better t…

zhouqt commented on pull request autotest/virt-test#1590
Tom Zhou

Hey @ypu, Could you please give me some hint for the advantage of this kind of 'reference count'? Why did you choose 'ref count' other than just bo…

zhouqt deleted branch provider-libs at zhouqt/tp-libvirt
zhouqt deleted branch next at zhouqt/autotest
zhouqt deleted branch virt-agent at zhouqt/autotest
zhouqt deleted branch usb at zhouqt/autotest
zhouqt deleted branch guest_agent at zhouqt/autotest
zhouqt deleted branch ext-ping at zhouqt/autotest
Something went wrong with that request. Please try again.