Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Can you add a license file to this repo? #6

Closed
shanewho opened this issue Jul 12, 2015 · 7 comments
Closed

Can you add a license file to this repo? #6

shanewho opened this issue Jul 12, 2015 · 7 comments

Comments

@shanewho
Copy link

I'm guessing the license would be LGPL like LAME?

@Dewsworld
Copy link

+1

@zhuker
Copy link
Owner

zhuker commented Aug 3, 2015

i am no big license experts
you think it should be LGPL? why? @shanewho @Dewsworld

@Dewsworld
Copy link

I am using a different library for converting mp3. This lib is lighter and simpler, was hoping to use in our project if all our requirements satisfy... I'm no expert in license either. Just to clarify if it's okay to use in our project.

@shanewho
Copy link
Author

shanewho commented Aug 3, 2015

I think it has to be LGPL because LAME is LGPL and so is jump3r-code. LGPL requires derivative work to be licensed under the same license. Here is the note in the license:

http://lame.sourceforge.net/license.txt

3. If you make modifications to LAME, you *must* release these
   modifications back to the LAME project, under the LGPL.

I would probably just copy the LICENSE file from the java code in your src/main/java/LICENSE to the root of your repository:

https://github.com/zhuker/lamejs/blob/master/src/main/java/LICENSE

@zhuker
Copy link
Owner

zhuker commented Aug 3, 2015

@shanewho done

@zhuker zhuker closed this as completed Aug 3, 2015
@shanewho
Copy link
Author

shanewho commented Aug 3, 2015

👍 Thanks!

@zhuker
Copy link
Owner

zhuker commented Aug 3, 2015

@Dewsworld - use at will, just mention you are using it, reference lamejs and lame somewhere and if you change it (like fix a bug) make your change available for everybody.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants