Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

@typeOf should presumably be called @TypeOf #1348

Closed
mdsteele opened this issue Aug 7, 2018 · 4 comments · Fixed by #5115
Closed

@typeOf should presumably be called @TypeOf #1348

mdsteele opened this issue Aug 7, 2018 · 4 comments · Fixed by #5115
Labels
accepted This proposal is planned. breaking Implementing this issue could cause existing code to no longer compile or have different behavior. contributor friendly This issue is limited in scope and/or knowledge of Zig internals. proposal This issue suggests modifications. If it also has the "accepted" label then it is planned.
Milestone

Comments

@mdsteele
Copy link
Contributor

mdsteele commented Aug 7, 2018

All the other builtin functions that return types (e.g. @ArgType, @OpaqueType, @TagType) are capitalized, matching the guidance in https://ziglang.org/documentation/master/#Names.

@thejoshwolfe
Copy link
Sponsor Contributor

agreed. this rename is planned; i think just nobody's gotten around to doing it yet.

@andrewrk
Copy link
Member

andrewrk commented Aug 7, 2018

Just to make this one easier on everyone, I'll wait until we're distributing zig fmt (e.g self hosted is done) and then I'll tag a commit where zig fmt will automatically fix this. I don't see a reason to do the rename before then.

@andrewrk andrewrk added this to the 0.4.0 milestone Aug 7, 2018
@andrewrk andrewrk added proposal This issue suggests modifications. If it also has the "accepted" label then it is planned. accepted This proposal is planned. labels Aug 7, 2018
@andrewrk andrewrk modified the milestones: 0.4.0, 0.5.0 Mar 14, 2019
@andrewrk andrewrk added the contributor friendly This issue is limited in scope and/or knowledge of Zig internals. label Apr 30, 2019
@andrewrk
Copy link
Member

OK so the current plan for these builtin renames (see also #2120) is:

  1. Make zig fmt allow both names but render to the canonical name
  2. After about 1 release cycle not even zig fmt will support the old name.

@andrewrk andrewrk added the breaking Implementing this issue could cause existing code to no longer compile or have different behavior. label Apr 30, 2019
@andrewrk andrewrk modified the milestones: 0.5.0, 0.6.0 Apr 30, 2019
@andrewrk
Copy link
Member

Gonna re-open this, just to track when we can remove support for auto-conversion. As soon as 0.6.0 is released, it's fair game to remove the legacy @typeOf support.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
accepted This proposal is planned. breaking Implementing this issue could cause existing code to no longer compile or have different behavior. contributor friendly This issue is limited in scope and/or knowledge of Zig internals. proposal This issue suggests modifications. If it also has the "accepted" label then it is planned.
Projects
None yet
Development

Successfully merging a pull request may close this issue.

3 participants