Join GitHub today
GitHub is home to over 31 million developers working together to host and review code, manage projects, and build software together.Sign up
audit line/column number accuracy of windows stack traces #1503
It seems that Windows stack traces are sometimes off by a line. Sometimes above, sometimes below.
One thing to double check: have a program manually print its
If those match then it should be a matter of how we are matching addresses with line/column data.
maybe this https://golang.org/pkg/debug/ specifically implementation of
I have not looked further though.
Doesn't look like it. I intentionally introduced an error in one of my projects and ran it on both Windows and Linux. The wrong line and carrot position problem persists.
#1798 did not fix this issue indeed.
I've been looking at this today and I'm puzzled.
The return addresses we keep in
However I can't see where the problem is. I hacked a bit in the windows source address printing to see if I could list all the source lines from a LineBlock, without any interesting results (and i'm not even sure I did it correctly as some line numbers didn't make sense).