Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Tier 1 support for 32 bit windows (i386-windows target) #537

Open
andrewrk opened this issue Oct 15, 2017 · 4 comments
Open

Tier 1 support for 32 bit windows (i386-windows target) #537

andrewrk opened this issue Oct 15, 2017 · 4 comments
Labels
arch-x86 contributor friendly enhancement os-windows stage1 standard library
Milestone

Comments

@andrewrk
Copy link
Member

andrewrk commented Oct 15, 2017

some of the math functions for 32-bit windows are not passing all tests. Grep the codebase for this issue url ("issues/537").

@andrewrk andrewrk added bug os-windows labels Oct 15, 2017
@andrewrk andrewrk added this to the 0.2.0 milestone Oct 15, 2017
andrewrk added a commit that referenced this issue Oct 15, 2017
@andrewrk
Copy link
Member Author

andrewrk commented Oct 15, 2017

This is effectively blocked by #516 (debug symbols don't work on windows)

@andrewrk andrewrk modified the milestone: 0.2.0 Oct 19, 2017
andrewrk added a commit that referenced this issue Nov 10, 2017
andrewrk added a commit that referenced this issue Dec 12, 2017
andrewrk added a commit that referenced this issue Dec 22, 2017
workaround windows 32 bit test failure
See #537
andrewrk added a commit that referenced this issue Jan 14, 2018
we still want to support it, but there are too many bugs
to claim that we support it right now.

See #537
@andrewrk andrewrk added enhancement and removed bug labels Jan 14, 2018
@andrewrk
Copy link
Member Author

andrewrk commented Jan 14, 2018

I removed 32 bit windows from the supported target list, because we had too many failing tests to justify it.

We still want to support it in a future release, but there's some debugging to be done.

cc @tiehuis

@andrewrk andrewrk changed the title failing tests on i386-windows target support 32 bit windows (i386-windows target) Jan 14, 2018
@andrewrk andrewrk modified the milestones: 0.2.0, 0.3.0 Jan 14, 2018
@andrewrk andrewrk modified the milestones: 0.3.0, 0.4.0 Feb 28, 2018
@andrewrk andrewrk modified the milestones: 0.4.0, 0.5.0 Feb 2, 2019
@andrewrk andrewrk changed the title support 32 bit windows (i386-windows target) Tier 1 support for 32 bit windows (i386-windows target) Feb 7, 2019
@andrewrk andrewrk added arch-x86 standard library contributor friendly stage1 labels Feb 7, 2019
@ljmccarthy
Copy link

ljmccarthy commented Apr 9, 2019

I recently tried building for this target and got a load of assembler syntax errors.

> zig build-exe -target i386-windows-msvc test.zig
<inline asm>:5:44: error: unknown token in expression
         mov         eax,dword ptr [esp+18h]
                                           ^
<inline asm>:8:44: error: unknown token in expression
         mov         ecx,dword ptr [esp+14h]
                                           ^
<inline asm>:9:44: error: unknown token in expression
         mov         eax,dword ptr [esp+10h]
                                           ^
...
LLVM ERROR: Error parsing inline asm

@emekoi
Copy link
Contributor

emekoi commented Jul 30, 2019

@andrewrk do you know what could be causing zig to emit this assembly?
related: https://reviews.llvm.org/D59810

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
arch-x86 contributor friendly enhancement os-windows stage1 standard library
Projects
None yet
Development

No branches or pull requests

3 participants