Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

diagnose and fix bug in mach-o LLD code: invalid x86_64 Reference Kind #662

Closed
andrewrk opened this issue Dec 19, 2017 · 4 comments
Closed

diagnose and fix bug in mach-o LLD code: invalid x86_64 Reference Kind #662

andrewrk opened this issue Dec 19, 2017 · 4 comments

Comments

@andrewrk
Copy link
Member

@andrewrk andrewrk commented Dec 19, 2017

Right now we have this patch applied to our in-tree fork of LLD:

ddca67a

It's an ugly workaround and does not solve the root cause. It's currently the only patch we have on top of LLD. If we fix this then we can go back to using upstream LLD.

Upstream bug: https://bugs.llvm.org/show_bug.cgi?id=32254

The bug is triggered by trivial hello world code. It seems the Mach-O LLD code is not well supported by the LLD team. Zig project will have to pick up the slack.

@andrewrk andrewrk added this to the 0.3.0 milestone Dec 19, 2017
@andrewrk andrewrk removed this from the 0.3.0 milestone Feb 28, 2018
@andrewrk andrewrk added this to the 0.4.0 milestone Feb 28, 2018
@andrewrk andrewrk removed this from the 0.4.0 milestone Feb 1, 2019
@andrewrk andrewrk added this to the 0.5.0 milestone Feb 1, 2019
@andrewrk
Copy link
Member Author

@andrewrk andrewrk commented Apr 8, 2019

Related: #1535

Loading

@LemonBoy
Copy link
Contributor

@LemonBoy LemonBoy commented May 21, 2019

I've sent a patch upstream.

Loading

@andrewrk andrewrk removed this from the 0.5.0 milestone Aug 27, 2019
@andrewrk andrewrk added this to the 0.6.0 milestone Aug 27, 2019
@andrewrk
Copy link
Member Author

@andrewrk andrewrk commented Aug 27, 2019

Loading

@andrewrk
Copy link
Member Author

@andrewrk andrewrk commented Oct 17, 2019

This has been fixed in trunk. We can finally drop the last LLD patch when LLVM 10 is released.

Loading

@andrewrk andrewrk closed this Oct 17, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Linked pull requests

Successfully merging a pull request may close this issue.

None yet
2 participants