Conversation
jacobly0
force-pushed
the
backend-fixes
branch
3 times, most recently
from
bd2b4ef to
0a898b5
Compare
|
I know this PR is still in draft, but could you extract 1cc6a95 into its own PR? It will make this and the new PR easier to review and we can merge the fixes separately from the C backend improvements. Especially as the fix contains changes to all of the native backends also, which was quite easy to miss from the title and description of this PR. |
|
Looking forward to this! |
jacobly0
force-pushed
the
backend-fixes
branch
6 times, most recently
from
329f3c9 to
d13bfb0
Compare
jacobly0
force-pushed
the
backend-fixes
branch
from
d13bfb0 to
9893abf
Compare
Interesting 🤔 I'm going to look into enhancing the lowering of inline assembly, so that it can automatically do these transforms (e.g. turning "{x8}" to "{i}" and inserting a "mov" when inside a naked function body). In the meantime, these hacks are nice workarounds 👍 |
|
Related: #13278 |
jacobly0
force-pushed
the
backend-fixes
branch
2 times, most recently
from
238d94d to
1b80daa
Compare
These ifs were missing a case for f80 which should have shifted by one, but we can just compute the correct value instead. Also, we want the fractional bits to be a multiple of four, not the mantissa bits, since the mantissa could have a leading one which we want to be separated.
* Enable advanced start support. * Enable advanced test_runner support. * Zig Language Reference's Hello World now works.
Global constant initializers can reference functions, so forward declare the constants and initialize them later with the function definitions, which guarantees that they appear after all declarations.
These are needed because clang doesn't support anything in naked functions, not even assembly register inputs.
Sometimes you have to break a test to make progress :)
jacobly0
force-pushed
the
backend-fixes
branch
from
1b80daa to
e20d2b3
Compare
|
Is this still intentionally a draft, or are you perhaps looking for review & merge now? |
|
This is in as good a state as any to review and merge. I can always open a new PR with further fixes. |
andrewrk
left a comment
andrewrk
left a comment
There was a problem hiding this comment.
Incredible work. This is ready to be merged.
3 participants
This enabled all of the behavior tests for the C backend that were passing and fixed all of the C warnings from the flags
-Wextra -Wall -pedanticfor the behavior tests except various unused (but set) and uninitalized (only with safety off) warnings, and then fixes a bunch of disabled behavior tests.Some notable C backend milestones achieved with these changes:
x86_64-linux(with and without libc).Fixes #12751
Fixes #11651