New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Find local llvm-config first #1378

Merged
merged 1 commit into from Aug 14, 2018

Conversation

Projects
None yet
2 participants
@prazzb
Contributor

prazzb commented Aug 13, 2018

Distro's llvm usually have a 6.0 suffix.Any custom llvm build
names the binary as llvm-config.Keeping 6.0 variant first causes
the distro's llvm to be compiled in place of a custom one even if
given using CMAKE_PREFIX_PATH.

Find local llvm-config first
Distro's llvm usually have a 6.0 suffix.Any custom llvm build
names the binary as llvm-config.Keeping 6.0 variant first causes
the distro's llvm to be compiled in place of a custom one even if
given using CMAKE_PREFIX_PATH.
@andrewrk

This comment has been minimized.

Member

andrewrk commented Aug 14, 2018

Hmm, the unfortunate side effect of this is that it could result in the wrong LLVM being chosen when the distro had multiple installed and llvm-config points to the non-6.0 one.

I think this is still probably better than status quo though.

@andrewrk andrewrk merged commit 52471f6 into ziglang:master Aug 14, 2018

2 checks passed

continuous-integration/appveyor/pr AppVeyor build succeeded
Details
continuous-integration/travis-ci/pr The Travis CI build passed
Details

@prazzb prazzb deleted the prazzb:cmake-fix branch Aug 15, 2018

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment