Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

breaking: let posixRead() return less than buffer size, introduce pos… #1414

Closed
wants to merge 1 commit into from

Conversation

Projects
None yet
2 participants
@shawnl
Copy link
Contributor

shawnl commented Aug 25, 2018

…ixReadFull()

posixRead should be as thin an abstraction on top of read() as possible.

posixReadFull() really should be in io somewhere.

How about importing all the abstractions from go's io? (we need traits for this)
https://golang.org/pkg/io/#ReadFull

@ghost

This comment has been minimized.

Copy link

ghost commented Aug 25, 2018

(we need traits for this)
#1268 (comment)

what do you think about this? 👍

@andrewrk

This comment has been minimized.

Copy link
Member

andrewrk commented Aug 25, 2018

I agree with you about posixReadFull vs posixRead. I believe @thejoshwolfe made this point before and there might even be an issue open regarding it. I'm going to do some more modifications on this PR before merging it though. Given that 0.3.0 is right around the corner I'm going to postpone that work for now.

@andrewrk andrewrk added this to the 0.4.0 milestone Aug 25, 2018

@shawnl shawnl force-pushed the shawnl:read branch 4 times, most recently from 4965d0d to df50d23 Aug 26, 2018

breaking: let posixRead() return less than buffer size, introduce pos…
…ixReadFull()

posixRead should be as thin an abstraction on top of read() as possible.

posixReadFull() really should be in io somewhere.

@shawnl shawnl force-pushed the shawnl:read branch from df50d23 to 9691422 Aug 28, 2018

@andrewrk andrewrk closed this in af229c1 Oct 1, 2018

@shawnl shawnl deleted the shawnl:read branch Mar 29, 2019

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
You can’t perform that action at this time.