New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Handle unions differently in std.fmt #1432

Merged
merged 2 commits into from Aug 27, 2018

Conversation

Projects
None yet
2 participants
@tgschultz
Contributor

tgschultz commented Aug 27, 2018

Print the active tag's value in tagged unions. Untagged unions considered unsafe to print and treated like a pointer or an array.

Handle unions differently in std.fmt
Print the active tag's value in tagged unions. Untagged unions considered unsafe to print and treated like a pointer or an array.
@andrewrk

This comment has been minimized.

Member

andrewrk commented Aug 27, 2018

I'm happy to create some test cases for this but do you have any examples handy you can paste for me here?

@tgschultz

This comment has been minimized.

Contributor

tgschultz commented Aug 27, 2018

Sorry, I realize my last few PRs have been particularly lazy. In fact, I made some errors here. I'll write up some tests.

@andrewrk andrewrk added this to the 0.4.0 milestone Aug 27, 2018

@andrewrk andrewrk modified the milestones: 0.4.0, 0.3.0 Aug 27, 2018

@andrewrk andrewrk merged commit ecc5464 into ziglang:master Aug 27, 2018

1 of 2 checks passed

continuous-integration/travis-ci/pr The Travis CI build could not complete due to an error
Details
continuous-integration/appveyor/pr AppVeyor build succeeded
Details
@andrewrk

This comment has been minimized.

Member

andrewrk commented Aug 27, 2018

Thanks!

@tgschultz tgschultz deleted the tgschultz:patch-4 branch Oct 23, 2018

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment