New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

compiling on mingw is now supported #1542

Merged
merged 6 commits into from Sep 18, 2018

Conversation

Projects
None yet
2 participants
@emekoi
Contributor

emekoi commented Sep 17, 2018

now the first stage compiler compiles and mingw. issue #1540.

@emekoi emekoi closed this Sep 17, 2018

@emekoi emekoi reopened this Sep 17, 2018

@andrewrk

This comment has been minimized.

Member

andrewrk commented Sep 18, 2018

This looks good to me! If it passes the appveyor tests I'll merge it. I'll try not to break the mingw build in the future, but please note that since we're unable to automatically test it, it's likely to break on occasion.

@emekoi

This comment has been minimized.

Contributor

emekoi commented Sep 18, 2018

all that kept it from building on mingw was a header include, 2 defines, and some compiler warnings promoted to errors by -Werror, so i don't think there's much chance of breaking changes. 😃

@andrewrk andrewrk merged commit 68c1d05 into ziglang:master Sep 18, 2018

2 checks passed

continuous-integration/appveyor/pr AppVeyor build succeeded
Details
continuous-integration/travis-ci/pr The Travis CI build passed
Details
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment