Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

crypto.pcurves: don't assume that points with X=0 are at infinity #16017

Merged
merged 1 commit into from
Jun 13, 2023
Merged

crypto.pcurves: don't assume that points with X=0 are at infinity #16017

merged 1 commit into from
Jun 13, 2023

Conversation

jedisct1
Copy link
Contributor

There's also a valid point with X=0 on each curves.

Fixes #16015

@jedisct1
crypto.pcurves: don't assume that points with X=0 are at infinity
e2c718c 
There's also a valid point with X=0 on each curves.

Fixes ziglang#16015
@jedisct1 jedisct1 enabled auto-merge (squash) June 13, 2023 14:19
ifreund
ifreund reviewed Jun 13, 2023
View reviewed changes
Copy link
Member

@ifreund ifreund left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Should this not have test cases added to ensure it does not regress? Or am I missing something?

@jedisct1
Copy link
Contributor Author

Yes, I'm gonna add a couple new test cases (not only for this) in a distinct PR.

@jedisct1 jedisct1 merged commit cc708b4 into ziglang:master Jun 13, 2023
@jedisct1 jedisct1 deleted the pcurves-infinity branch June 13, 2023 23:18
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ifreund ifreund ifreund left review comments

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Incorrect serialization of elliptic curve point whose X = 0
2 participants
@jedisct1 @ifreund