Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Bug fixes in WinSDK detection #1665

Merged
merged 3 commits into from Oct 24, 2018

Conversation

Projects
None yet
2 participants
@dimenus
Copy link
Contributor

dimenus commented Oct 19, 2018

@andrewrk I think your note about Microsoft releasing the latest build of the WinSDK as 10240 is incorrect, and that seems to be backed up by file dates & sizes of the libs.

This PR fixes a couple bugs with the current implementation.

  • We now grab the most recent version of the Windows SDK that's been installed. This is how clang implements their detection scheme as well.

  • We now also check that the specific (libc) components are installed rather than just checking the existence of the folder. Unfortunately, those are separate items in the MSVC installer so it's possible to have the folder exist without having the proper components installed.

@andrewrk
Copy link
Member

andrewrk left a comment

Thanks for the followup!

Show resolved Hide resolved src/windows_sdk.cpp Outdated
Show resolved Hide resolved src/windows_sdk.cpp Outdated

andrewrk and others added some commits Oct 24, 2018

Update src/windows_sdk.cpp
Co-Authored-By: dimenus <rsdimenus@gmail.com>
Update src/windows_sdk.cpp
Co-Authored-By: dimenus <rsdimenus@gmail.com>

@andrewrk andrewrk merged commit 73ab0af into ziglang:master Oct 24, 2018

0 of 2 checks passed

continuous-integration/appveyor/pr Waiting for AppVeyor build to complete
Details
continuous-integration/travis-ci/pr The Travis CI build is in progress
Details
@andrewrk

This comment has been minimized.

Copy link
Member

andrewrk commented Oct 24, 2018

Really appreciate this improvement 💯

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
You can’t perform that action at this time.