Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Prevent crash in tagged enums rendering #1986

Merged
merged 2 commits into from Feb 19, 2019

Conversation

Projects
None yet
2 participants
@LemonBoy
Copy link
Contributor

LemonBoy commented Feb 19, 2019

Fixes #1948

@andrewrk

This comment has been minimized.

Copy link
Member

andrewrk commented Feb 19, 2019

Can you add a test case for this? Either to test/compile_errors.zig or to test/stage1/behavior/*

@andrewrk
Copy link
Member

andrewrk left a comment

Looks good! If you can confirm that you ran test-compile-errors locally and your new test passed, I'll merge this even before the CI completes. Here is how you would do that:

make install && ./zig build --build-file ../build.zig -Dskip-release test-compile-errors

Also you are welcome to put the new compile_errors.zig test at the very beginning so that it runs first, and you can ctrl+c the above test after it finishes your new one.

@LemonBoy

This comment has been minimized.

Copy link
Contributor Author

LemonBoy commented Feb 19, 2019

If you can confirm that you ran test-compile-errors locally and your new test passed

I guess it's good to go.

Test 1/4 compile-error compileLog of tagged enum doesn't crash the compiler (Debug)...OK
Test 2/4 compile-error compileLog of tagged enum doesn't crash the compiler (ReleaseSafe)...OK
Test 3/4 compile-error compileLog of tagged enum doesn't crash the compiler (ReleaseFast)...OK
Test 4/4 compile-error compileLog of tagged enum doesn't crash the compiler (ReleaseSmall)...OK

@andrewrk andrewrk merged commit 400006b into ziglang:master Feb 19, 2019

0 of 2 checks passed

builds.sr.ht: freebsd.yml builds.sr.ht job is running
Details
ziglang.zig in progress
Details
@andrewrk

This comment has been minimized.

Copy link
Member

andrewrk commented Feb 19, 2019

Thanks!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
You can’t perform that action at this time.