map EBADF to error values for read and write #5745
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
kubkon
reviewed
Jun 29, 2020
Member
|
Thanks @lun-4 for your patience on this one. Good stuff |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes #3880.
I took a peek at the other syscall wrappers around
std.osand found inconsistencies on what EBADF means for them. Some declare EBADF as "not open file descriptor" (fchdir, lseek, llseek), or "not valid open file descriptor" (mmap), and others put their own meanings as well (fcntl, unlinkat, mkdirat, fstatat), which makes me think about if we should return error values on those calls too.Also, I didn't change anything regarding WASI errors.WASI maps errors as well.