New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix some errors in std.io #877

Merged
merged 1 commit into from Mar 31, 2018

Conversation

Projects
None yet
2 participants
@raulgrell
Contributor

raulgrell commented Mar 31, 2018

Fix undeclared identifier error in readUntilDelimiterBuffer and incorrect number of parameters in readUntilDelimiterAlloc

Fix undeclared identifier error in readUntilDelimiterBuffer and incor…
…rect number of parameters in readUntilDelimiterAlloc
@andrewrk

Looks good. I'm going to add a unit test before merging.

@raulgrell

This comment has been minimized.

Contributor

raulgrell commented Mar 31, 2018

I figured there was no need since it was essentially a typo =)

I'll keep an eye out for any more std lib functions that don't have tests

@andrewrk

This comment has been minimized.

Member

andrewrk commented Mar 31, 2018

Yeah, you know, this is fine. We can do some test coverage analysis on the stdlib before 1.0.0.

@andrewrk andrewrk merged commit eb6ff79 into ziglang:master Mar 31, 2018

2 checks passed

continuous-integration/appveyor/pr AppVeyor build succeeded
Details
continuous-integration/travis-ci/pr The Travis CI build passed
Details
@andrewrk

This comment has been minimized.

Member

andrewrk commented Mar 31, 2018

thanks!

@raulgrell raulgrell deleted the raulgrell:stdlib branch Apr 2, 2018

@raulgrell raulgrell restored the raulgrell:stdlib branch Apr 2, 2018

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment