New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add round e-ink meter with external wired outdoor sensor #2119
Conversation
Pull Request Test Coverage Report for Build 3966363638
💛 - Coveralls |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Now its looks nice :-)))
Codecov ReportBase: 83.60% // Head: 83.60% // No change to project coverage 👍
Additional details and impacted files@@ Coverage Diff @@
## dev #2119 +/- ##
=======================================
Coverage 83.60% 83.60%
=======================================
Files 254 254
Lines 8156 8156
=======================================
Hits 6819 6819
Misses 1337 1337
Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here. ☔ View full report at Codecov. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Judging from #2113, these changes seem to work and LGTM.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
Upppps, |
Thanks for your contribution! It's rare but apparently someone was a bit faster and also added the same sensor in this PR: #2117 |
No description provided.