Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add round e-ink meter with external wired outdoor sensor #2119

Closed
wants to merge 2 commits into from
Closed

Add round e-ink meter with external wired outdoor sensor #2119

wants to merge 2 commits into from

Conversation

m0nty81
Copy link

@m0nty81 m0nty81 commented Jan 20, 2023

No description provided.

@coveralls
Copy link

coveralls commented Jan 20, 2023

Pull Request Test Coverage Report for Build 3966363638

  • 0 of 0 changed or added relevant lines in 0 files are covered.
  • No unchanged relevant lines lost coverage.
  • Overall coverage remained the same at 83.607%

Totals Coverage Status
Change from base Build 3949168313: 0.0%
Covered Lines: 6819
Relevant Lines: 8156

💛 - Coveralls

Copy link
Contributor

@MattWestb MattWestb left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Now its looks nice :-)))

@codecov-commenter
Copy link

Codecov Report

Base: 83.60% // Head: 83.60% // No change to project coverage 👍

Coverage data is based on head (634b7be) compared to base (a16c153).
Patch has no changes to coverable lines.

Additional details and impacted files
@@           Coverage Diff           @@
##              dev    #2119   +/-   ##
=======================================
  Coverage   83.60%   83.60%           
=======================================
  Files         254      254           
  Lines        8156     8156           
=======================================
  Hits         6819     6819           
  Misses       1337     1337           
Impacted Files Coverage Δ
zhaquirks/tuya/ts0601_sensor.py 100.00% <ø> (ø)

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

☔ View full report at Codecov.
📢 Do you have feedback about the report comment? Let us know in this issue.

Copy link
Collaborator

@TheJulianJES TheJulianJES left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Judging from #2113, these changes seem to work and LGTM.

@TheJulianJES TheJulianJES added Tuya Request/PR regarding a Tuya device ready PR should be ready to merge labels Jan 20, 2023
Copy link
Collaborator

@javicalle javicalle left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@javicalle
Copy link
Collaborator

javicalle commented Jan 20, 2023

Upppps,
Duplicate of #2117

@javicalle javicalle marked this as a duplicate of #2117 Jan 20, 2023
@TheJulianJES TheJulianJES added the duplicate This issue or pull request already exists label Jan 20, 2023
@TheJulianJES
Copy link
Collaborator

Thanks for your contribution!

It's rare but apparently someone was a bit faster and also added the same sensor in this PR: #2117

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
duplicate This issue or pull request already exists ready PR should be ready to merge Tuya Request/PR regarding a Tuya device
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

6 participants