OSRAM/LEDVANCE Gardenpole Integration (save_defaults) #459
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
dmulcahey
reviewed
Aug 22, 2020
zhaquirks/osram/gardenpolesrgbw.py
Outdated
| ) | ||
|
|
||
|
|
||
| class FlexRGBW(CustomDevice): |
There was a problem hiding this comment.
Change this to reflect the actual product please.
dmulcahey
reviewed
Aug 22, 2020
zhaquirks/osram/gardenpolesrgbw.py
Outdated
| replacement = { | ||
| ENDPOINTS: { | ||
| 3: { | ||
| PROFILE_ID: zha.PROFILE_ID, |
There was a problem hiding this comment.
Why are you changing the profile id?
dmulcahey
reviewed
Aug 22, 2020
zhaquirks/osram/gardenpolesrgbw.py
Outdated
| ENDPOINTS: { | ||
| 3: { | ||
| PROFILE_ID: zha.PROFILE_ID, | ||
| DEVICE_TYPE: zha.DeviceType.COLOR_DIMMABLE_LIGHT, |
There was a problem hiding this comment.
Same as above? Why the switch from zll to zha?
|
Sorry. Somehow I thought I already finished this yesterday - I'll actually review future submissions. |
|
Lint is failing because zha is still imported but unused. No need to be sorry! We all do it :) |
dmulcahey
approved these changes
Aug 22, 2020
|
Thanks! |
This was referenced Sep 16, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #449