Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix urinorm - return plain sub delimiters in path #43

Merged
merged 1 commit into from Jul 8, 2020
Merged

Conversation

ziima
Copy link
Owner

@ziima ziima commented Jul 2, 2020

Reduce the strictness of percent encoding in path of urinorm as reported in #41

@codecov-commenter
Copy link

codecov-commenter commented Jul 2, 2020

Codecov Report

Merging #43 into master will increase coverage by 0.00%.
The diff coverage is 100.00%.

Impacted file tree graph

@@           Coverage Diff           @@
##           master      #43   +/-   ##
=======================================
  Coverage   89.48%   89.49%           
=======================================
  Files          93       93           
  Lines       12015    12019    +4     
  Branches     1084     1084           
=======================================
+ Hits        10752    10756    +4     
  Misses       1094     1094           
  Partials      169      169           
Impacted Files Coverage Δ
openid/test/test_urinorm.py 100.00% <100.00%> (ø)
openid/urinorm.py 91.20% <100.00%> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 4b0cbbf...aba0333. Read the comment docs.

@tpazderka
Copy link
Collaborator

tpazderka commented Jul 2, 2020

LGTM, so waiting for confirmation from #41.

@cjwatson
Copy link

cjwatson commented Jul 6, 2020

Thanks! Can this be merged now?

@ziima ziima merged commit 7d26c7f into master Jul 8, 2020
4 checks passed
@ziima ziima deleted the fix-urinorm-path branch Jul 8, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants