diff --git a/Controller/ConfigController.php b/Controller/ConfigController.php index 64a62b0..ea41d26 100644 --- a/Controller/ConfigController.php +++ b/Controller/ConfigController.php @@ -66,7 +66,7 @@ public function configAction(Request $request) ]; // get all user groups - // TODO legacy call + // @todo legacy call $groups = ModUtil::apiFunc('ZikulaGroupsModule', 'user', 'getall'); foreach ($groups as $group) { $groupChoices[$group['name']] = $group['gid']; diff --git a/Helper/ResetAgreementHelper.php b/Helper/ResetAgreementHelper.php index 65a47ad..bc82323 100644 --- a/Helper/ResetAgreementHelper.php +++ b/Helper/ResetAgreementHelper.php @@ -80,7 +80,7 @@ public function reset($groupId = -1) // single group // get the group incl members - // TODO legacy call + // @todo legacy call $grp = ModUtil::apiFunc('ZikulaGroupsModule', 'user', 'get', ['gid' => $groupId]); if ($grp == false) { return false; diff --git a/Listener/EuCookieWarningInjectorListener.php b/Listener/EuCookieWarningInjectorListener.php index 6d658b3..a517149 100644 --- a/Listener/EuCookieWarningInjectorListener.php +++ b/Listener/EuCookieWarningInjectorListener.php @@ -11,13 +11,15 @@ namespace Zikula\LegalModule\Listener; -use ModUtil; use Symfony\Component\EventDispatcher\EventSubscriberInterface; use Symfony\Component\HttpFoundation\Request; use Symfony\Component\HttpFoundation\Response; use Symfony\Component\HttpKernel\Event\FilterResponseEvent; use Symfony\Component\HttpKernel\KernelEvents; +use Symfony\Component\Translation\TranslatorInterface; +use Zikula\ExtensionsModule\Api\VariableApi; use Zikula\LegalModule\Constant as LegalConstant; +use Zikula\ThemeModule\Engine\Asset; /** * EuCookieWarningInjectorListener injects a warning to the user that cookies are @@ -30,10 +32,39 @@ */ class EuCookieWarningInjectorListener implements EventSubscriberInterface { + /** + * @var TranslatorInterface + */ + private $translator; + + /** + * @var VariableApi + */ + private $variableApi; + + /** + * @var Asset + */ + private $assetHelper; + + /** + * @var string + */ private $stylesheetOverride; - public function __construct($stylesheetOverride = null) + /** + * Constructor. + * + * @param TranslatorInterface $translator Translator service instance + * @param VariableApi $variableApi VariableApi service instance + * @param Asset $assetHelper Asset service instance + * @param string $stylesheetOverride Custom path to css file (optional) + */ + public function __construct(TranslatorInterface $translator, VariableApi $variableApi, Asset $assetHelper, $stylesheetOverride = null) { + $this->translator = $translator; + $this->variableApi = $variableApi; + $this->assetHelper = $assetHelper; $this->stylesheetOverride = $stylesheetOverride; } @@ -54,9 +85,8 @@ public function onKernelResponse(FilterResponseEvent $event) return; } - // is modvar enabled? - // TODO legacy call - $cookieSetting = ModUtil::getVar(LegalConstant::MODNAME, LegalConstant::MODVAR_EUCOOKIE); + // is functionality enabled? + $cookieSetting = $this->variableApi->get(LegalConstant::MODNAME, LegalConstant::MODVAR_EUCOOKIE); if (empty($cookieSetting)) { return; } @@ -83,13 +113,11 @@ protected function injectWarning(Request $request, Response $response) // add javascript to bottom of body $pos = strripos($content, ''); if (false !== $pos) { - // TODO legacy call - $module = ModUtil::getModule(LegalConstant::MODNAME); - $path = $request->getBasePath().'/'.$module->getRelativePath().'/Resources/public/js/jquery.cookiebar/jquery.cookiebar.js'; + $path = $this->assetHelper->resolve('@ZikulaLegalModule:js/jquery.cookiebar/jquery.cookiebar.js'); $javascript = ''; // allow translation of content - $message = __('We use cookies to track usage and preferences', $module->getTranslationDomain()); - $acceptText = __('I Understand', $module->getTranslationDomain()); + $message = $this->translator->__('We use cookies to track usage and preferences'); + $acceptText = $this->translator->__('I Understand'); $javascript .= '