Skip to content

Commit

Permalink
Fixed and cleaned up Blocks javascript.
Browse files Browse the repository at this point in the history
  • Loading branch information
cmfcmf committed Oct 13, 2013
1 parent bf76a77 commit c5628d0
Show file tree
Hide file tree
Showing 7 changed files with 96 additions and 73 deletions.
5 changes: 3 additions & 2 deletions build.xml
Expand Up @@ -10,7 +10,7 @@
BUILD_NUMBER - The current build number, such as "153"
BUILD_ID - The current build id, (YYYY-MM-DD_hh-mm-ss)
JOB_NAME - Name of the project of this build, such as "foo"
BUILD_TAG - String of "jenkins-${JOBNAME}-${BUILD_NUMBER}".
BUILD_TAG - String of "jenkins-${JOB_NAME}-${BUILD_NUMBER}".
WORKSPACE - The absolute path of the workspace.
SVN_REVISION - The revision this build is based on.
-->
Expand All @@ -33,7 +33,8 @@
javascript/helpers/Zikula.UI.js,
system/Zikula/Module/AdminModule/Resources/public/js/admin_admin_ajax.js,
system/Zikula/Module/AdminModule/Resources/public/js/admin_admin_modifyconfig.js,
system/Zikula/Module/BlocksModule/Resources/public/js/blocks.js,
system/Zikula/Module/BlocksModule/Resources/public/js/Zikula.Blocks.Admin.Common.js,
system/Zikula/Module/BlocksModule/Resources/public/js/Zikula.Blocks.Admin.Modifyposition.js,
system/Zikula/Module/BlocksModule/Resources/public/js/contextmenu.js,
system/Zikula/Module/BlocksModule/Resources/public/js/functions.js,
system/Zikula/Module/BlocksModule/Resources/public/js/Zikula.Menutree.Tree.js,
Expand Down
@@ -0,0 +1,24 @@
// Copyright Zikula Foundation 2013 - license GNU/LGPLv3 (or at your option, any later version).

/*******************************************************************************
* Toggle block
*******************************************************************************/
( function($) {
$(document).ready(function() {
$('.z-admin-content .label[data-bid]').click( function(e) {
e.preventDefault();
var a = $(this)
$.ajax({
url: 'index.php?module=ZikulaBlocksModule&type=ajax&func=toggleblock',
data: {
bid: a.data('bid')
},
success: function(response) {
// toggle label
a.parent().find('a').toggleClass('hide');

}
});
});
});
})(jQuery);
@@ -0,0 +1,60 @@
// Copyright Zikula Foundation 2013 - license GNU/LGPLv3 (or at your option, any later version).

/*******************************************************************************
* Sort blocks in a block position
*******************************************************************************/
( function($) {$(document).ready(function() {

// Return a helper with preserved width of cells
var fixHelper = function(e, ui) {
ui.children().each(function() {
$(this).width($(this).width());
});
return ui;
};

$("#assignedblocklist tbody").sortable({
connectWith: "#unassignedblocklist tbody",
helper: fixHelper,
placeholder: "warning",
update: function(event, ui) {
// Make sure to always show a dropzone.
if ($('#assignedblocklist tbody tr').length <= 1) {
$('#assignedblocklist .sortable-placeholder').fadeIn();
} else {
$('#assignedblocklist .sortable-placeholder').fadeOut();
}

var blockorder = new Array();
$('#assignedblocklist > tbody > tr').each( function() {
var bid = $(this).data('bid');
if (bid !== undefined) {
blockorder.push(bid);
}
});

$.ajax({
url: 'index.php?module=ZikulaBlocksModule&type=ajax&func=changeblockorder',
data: {
position: $('#position').val(),
blockorder: blockorder
}
});
}
}).disableSelection();

$("#unassignedblocklist tbody").sortable({
connectWith: "#assignedblocklist tbody",
helper: fixHelper,
placeholder: "warning",
update: function(event, ui) {
// Make sure to always show a dropzone.
if ($('#unassignedblocklist tbody tr').length <= 1) {
$('#unassignedblocklist .sortable-placeholder').fadeIn();
} else {
$('#unassignedblocklist .sortable-placeholder').fadeOut();
}
}
}).disableSelection();

});})(jQuery);

This file was deleted.

@@ -1,4 +1,5 @@
{pageaddvar name='javascript' value='system/Zikula/Module/BlocksModule/Resources/public/js/blocks.js'}
{pageaddvar name='javascript' value='system/Zikula/Module/BlocksModule/Resources/public/js/Zikula.Blocks.Admin.Common.js'}
{pageaddvar name='javascript' value='system/Zikula/Module/BlocksModule/Resources/public/js/Zikula.Blocks.Admin.Modifyposition.js'}
{pageaddvar name='javascript' value='jquery-ui'}
{adminheader}
<h3>
Expand Down Expand Up @@ -53,6 +54,9 @@
</tr>
</thead>
<tbody>
<tr {if !empty($assignedblocks)}style="display: none;"{/if}class="sortable-placeholder">
<td class="warning" colspan="7">{gt text='No blocks assigned yet.'}</td>
</tr>
{foreach item=block from=$assignedblocks}
<tr data-bid="{$block.bid}">
<td><span class="icon icon-move"></span></td>
Expand Down Expand Up @@ -84,6 +88,9 @@
</tr>
</thead>
<tbody>
<tr {if !empty($unassignedblocks)}style="display: none;"{/if}class="sortable-placeholder">
<td class="warning" colspan="7">{gt text='All blocks assigned.'}</td>
</tr>
{foreach item=block from=$unassignedblocks}
<tr data-bid="{$block.bid}">
<td><span class="icon icon-move"></span></td>
Expand Down
@@ -1,4 +1,4 @@
{pageaddvar name='javascript' value='system/Zikula/Module/BlocksModule/Resources/public/js/blocks.js'}
{pageaddvar name='javascript' value='system/Zikula/Module/BlocksModule/Resources/public/js/Zikula.Blocks.Admin.Common.js'}

{gt text="Click to activate this block" assign=activate}
{gt text="Click to deactivate this block" assign=deactivate}
Expand Down
@@ -1,4 +1,3 @@
{ajaxheader modname="Blocks" filename="blocks.js"}
{pageaddvar name="javascript" value="javascript/helpers/Zikula.itemlist.js"}
{pageaddvar name="stylesheet" value="system/Zikula/Module/BlocksModule/Resources/public/css/extmenu_modify.css"}
{pageaddvarblock}
Expand Down

0 comments on commit c5628d0

Please sign in to comment.