Better script for viewing images #3362

Closed
Guite opened this Issue Jan 3, 2017 · 12 comments

Projects

None yet

4 participants

@Guite
Member
Guite commented Jan 3, 2017

The currently included media-lightbox script from https://github.com/bootstrap-plus/bootstrap-media-lightbox/ has issues with different browsers.
Thus, I propose to replace it by something more matured, like:

https://github.com/lokesh/lightbox2/
http://lokeshdhakar.com/projects/lightbox2/

@Guite Guite added the Javascript label Jan 3, 2017
@Guite Guite added this to the 1.4.6 milestone Jan 3, 2017
@rallek
Contributor
rallek commented Jan 3, 2017

+1

@Portugao
Portugao commented Jan 3, 2017

👍

@Guite Guite self-assigned this Jan 8, 2017
@craigh
Member
craigh commented Jan 26, 2017

BC concerns?

@Guite
Member
Guite commented Jan 26, 2017

Not sure. The script to bei replaced was introduced in 1.4 iirc.

@rallek
Contributor
rallek commented Jan 26, 2017

Both in parallel results in problems on my site.

@Guite Guite modified the milestone: 1.4.7, 1.4.6 Jan 30, 2017
@rallek
Contributor
rallek commented Feb 2, 2017

I would love to see this in 1.4.6. Is there anything I can help?

@Guite Guite added the Feature label Feb 2, 2017
@Guite
Member
Guite commented Feb 2, 2017

Atm this is blocked by missing composer support, see lokesh/lightbox2#467

@Guite Guite modified the milestone: 1.4.6, 1.4.7 Feb 2, 2017
@Guite
Member
Guite commented Feb 2, 2017

See #3435

The bootstrap-media-lightbox should be removed in the master branch after this has been merged to both 1.4 and master.

@craigh
Member
craigh commented Feb 2, 2017

So the plan is that both are avaialable until 2.0 yes?

@Guite
Member
Guite commented Feb 2, 2017

This is the easiest way I guess.

@craigh
Member
craigh commented Feb 2, 2017

well it's the only way to maintain BC within the current branch

@Guite Guite closed this Feb 2, 2017
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment