remove *.class parameters #3371

Closed
craigh opened this Issue Jan 7, 2017 · 2 comments

Projects

None yet

2 participants

@craigh
Member
craigh commented Jan 7, 2017

apparently at one time symfony considered it "best practice" to parameterize all class assignments. This apparently creates unnecessary overhead and degrades performance for no reason.

symfony/symfony#11881

We are inconsistent in our definitions - sometimes using parameters and sometimes not.

So - we should eliminate the parameters (*.class) and use the classnames directly in the definition.

Using these class parameters , we override these symfony services that I know of:

  1. EventDispatcher
  2. ControllerResolver
  3. Sessions
  4. Translator (or maybe not?)

There may be additional definitions I am unaware of. We would need to thoroughly check.

In Symfony 3 these no longer work (although I cannot find documentation of this in the upgrading documents...) We need to explicitly define the service, thus overriding the class or decorate them instead.

@craigh craigh added the Symfony label Jan 7, 2017
@craigh craigh added this to the 1.4.6 milestone Jan 7, 2017
@craigh craigh self-assigned this Jan 7, 2017
@Guite
Member
Guite commented Jan 7, 2017

eliminate the parameters (*.class)

nice 👍 I dislike these anyway 😄

@craigh craigh referenced this issue in Guite/MostGenerator Jan 8, 2017
Closed

remove *.class parameters #928

@craigh
Member
craigh commented Jan 9, 2017

fixed in #3374

@craigh craigh closed this Jan 9, 2017
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment