New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Users Module can not sent mail #3863

Closed
rallek opened this Issue Nov 27, 2017 · 8 comments

Comments

Projects
None yet
4 participants
@rallek
Copy link
Contributor

rallek commented Nov 27, 2017

Q A
Zikula Version 1.5.3
PHP Version 5.6

Expected behavior

Via Find/Mail/Delete Users a mail should be sent to a user

Actual behavior

mail is not send

Steps to reproduce

grafik

leads to
grafik

@craigh

This comment has been minimized.

Copy link
Member

craigh commented Nov 27, 2017

this is likely a server configuration or mail configuration problem. not zikula. Zikula uses swift mailer which is a well-tested third party vendor.

@rallek

This comment has been minimized.

Copy link
Contributor

rallek commented Nov 28, 2017

I am on shared hosting. The test mail is running well. What can I do to make it running?

@Kaik

This comment has been minimized.

Copy link
Contributor

Kaik commented Nov 28, 2017

I just checked and it does not send mail... localhost, zikula1.5.2/php7x same setup/install where Dizkus is sending, well at least profiler is saying mail was sent. In this case just "Could not send mail."

@craigh craigh added the Bug label Nov 28, 2017

@craigh craigh added this to the 1.5.4 milestone Nov 28, 2017

@Guite

This comment has been minimized.

Copy link
Member

Guite commented Dec 1, 2017

This looks like a logical issue in MailHelper#mailUsers():

In https://github.com/zikula/core/blob/1.5/src/system/UsersModule/Helper/MailHelper.php#L194 $mailSent is initialised with false. Afterwards there are several assignments like $mailSent = $mailSent && .... So $mailSent never becomes true.

@craigh please confirm

@Guite

This comment has been minimized.

Copy link
Member

Guite commented Dec 1, 2017

Proposed fix: initialise the variable with true in line 194.

Guite added a commit that referenced this issue Dec 2, 2017

@Guite Guite referenced this issue Dec 2, 2017

Merged

fixed #3863 #3865

Guite added a commit that referenced this issue Dec 2, 2017

@Guite

This comment has been minimized.

Copy link
Member

Guite commented Dec 2, 2017

Fixed by #3865

@Guite Guite closed this Dec 2, 2017

@Kaik

This comment has been minimized.

Copy link
Contributor

Kaik commented Dec 2, 2017

That $mailSent marker why is it needed at all? It should be false at the beginning and without && I think... maybe for that foreach only but then if only one mailing returns false all are false?

@Guite

This comment has been minimized.

Copy link
Member

Guite commented Dec 2, 2017

It just determines if the entire operation worked or not. Having a more comprehensive feedback (like which mails to which users were sent correctly and which not) would be a new feature.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment