Join GitHub today
GitHub is home to over 28 million developers working together to host and review code, manage projects, and build software together.Sign up
Cleanup Users and ZAuth redundancies #3913
Review validators and check which ones make sense to exist in both modules and which not.
The email validator is exactly identical.
Also a modvar is used at https://github.com/zikula/core/blob/2.0/src/system/ZAuthModule/Validator/Constraints/ValidEmailValidator.php#L66 but never initialised at https://github.com/zikula/core/blob/2.0/src/system/ZAuthModule/ZAuthModuleInstaller.php#L71
the validators are intentionally duplicated
consider - ZAuth may not be the module which authenticates the user (e.g. OAuth, etc). The Authentication module must validate its own values. In addition, the core must validate users as they are added.
The modvar being used should be obtained from the
I wrestled with all these decisions some time ago. At the time, I determined this was the best approach. I cannot recall all my thoughts, but suffice to say that all options were carefully considered. Self-containment was certainly part of the thought process. Obviously, I am typically not in favor of code duplication... but at the time, it made sense for me to do so.