Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Avoid URL field for themes #4353

Closed
Guite opened this issue Jun 22, 2020 · 7 comments · Fixed by #4385
Closed

Avoid URL field for themes #4353

Guite opened this issue Jun 22, 2020 · 7 comments · Fixed by #4385
Assignees
Labels
Milestone

Comments

@Guite
Copy link
Member

@Guite Guite commented Jun 22, 2020

The URL field should be hidden (and not required) for themes.

grafik

cc @gfr

@Guite Guite added the Bug label Jun 22, 2020
@Guite Guite added this to the 3.0.1 milestone Jun 22, 2020
@craigh
Copy link
Member

@craigh craigh commented Jun 22, 2020

why? you are even using one in the bootstrap theme.

@Guite
Copy link
Member Author

@Guite Guite commented Jun 22, 2020

Right. But it shouldn't be required then, should it?

@Guite
Copy link
Member Author

@Guite Guite commented Jun 22, 2020

If it should be required, then we need to add it to the theme's composer.json, like we do it for modules, too.

@craigh craigh removed the Bug label Jun 22, 2020
@craigh
Copy link
Member

@craigh craigh commented Jun 22, 2020

so, I don't think you actually used one in BootstrapTheme. (it appears the route is simply /ajax/foo instead of /bootstrap/ajax/foo

I don't see this as a bug. It is functional as is.

What case brought this up?

@Guite
Copy link
Member Author

@Guite Guite commented Jun 22, 2020

No specific case. It is just confusing if you want to edit the theme data and don't know what you need to input in the field which is empty but required.

@craigh
Copy link
Member

@craigh craigh commented Jun 22, 2020

ah - I see. then it is not functional as is.

still, the problem is bigger than a UI concern.

@craigh craigh added the Bug label Jun 22, 2020
@Guite
Copy link
Member Author

@Guite Guite commented Jul 8, 2020

This will be done in two steps:

  1. make the URL input field optional in 3.0.1 (but only for themes) in order to make the input form less confusing for people editing a theme.
  2. postpone the issue for making the URL a requirement for themes meta data in 4.0.0 (create a different issue for that).

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants