Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

improve initialize check in VariableApi #4360

Closed
Guite opened this issue Jun 25, 2020 · 2 comments · Fixed by #4388
Closed

improve initialize check in VariableApi #4360

Guite opened this issue Jun 25, 2020 · 2 comments · Fixed by #4388
Assignees
Labels
Milestone

Comments

@Guite
Copy link
Member

@Guite Guite commented Jun 25, 2020

Inside VariableApi check if the system is installed.
This check can then be removed from some listeners that only do it to prevent access to the module_vars table.

@Guite Guite added this to the 3.0.1 milestone Jun 25, 2020
@Guite
Copy link
Member Author

@Guite Guite commented Jun 25, 2020

Already done.

@Guite Guite closed this as completed Jun 25, 2020
@Guite Guite modified the milestones: 3.0.1, Discarded Tickets Jun 25, 2020
@craigh craigh modified the milestones: Discarded Tickets, 3.0.1 Jun 25, 2020
@craigh
Copy link
Member

@craigh craigh commented Jun 25, 2020

I'd like to make some modifications to VariableApi based on this.

for example - currently, it makes this check in most methods:

    if (!$this->isInitialized) {
        $this->initialize();
    }

but if core is not installed, then the initialize fails, but the method continues as if it succeeded.

If initialize fails, the method should not continue.

@craigh craigh reopened this Jun 25, 2020
@craigh craigh changed the title Centralise installation check in VariableApi improve initialize check in VariableApi Jun 25, 2020
@Guite Guite self-assigned this Jul 9, 2020
@Guite Guite linked a pull request Jul 9, 2020 that will close this issue
@Guite Guite added the Refactor label Jul 9, 2020
@Guite Guite closed this as completed Jul 9, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants