Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add handling for missing case in Asset class #4366

Closed
Guite opened this issue Jul 1, 2020 · 1 comment
Closed

Add handling for missing case in Asset class #4366

Guite opened this issue Jul 1, 2020 · 1 comment
Assignees
Labels
Milestone

Comments

@Guite
Copy link
Member

@Guite Guite commented Jul 1, 2020

If a normal asset (non zasset) path does not exist in the public folder yet we run into a problem because this check returns false. Afterwards we have an undefined/wrong behaviour because then it proceeds with the bundle resolving sections although a normal path is given. As a result, this line results in Notice: Undefined offset: 1.
So the least we should do is throwing an exception in line 99 then. Or if possible copy the missing file (as a fallback) and return its path afterwards.

@Guite Guite added the Bug label Jul 1, 2020
@Guite Guite added this to the 3.0.1 milestone Jul 1, 2020
@craigh craigh self-assigned this Jul 1, 2020
craigh added a commit that referenced this issue Jul 10, 2020
* throw exception when asset not found. fixes #4366
@craigh
Copy link
Member

@craigh craigh commented Jul 10, 2020

closed by #4392

@craigh craigh closed this as completed Jul 10, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

No branches or pull requests

2 participants