Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

theme bootstrap override asset not copied on install #4367

Closed
craigh opened this issue Jul 1, 2020 · 2 comments
Closed

theme bootstrap override asset not copied on install #4367

craigh opened this issue Jul 1, 2020 · 2 comments
Assignees
Labels
Milestone

Comments

@craigh
Copy link
Member

@craigh craigh commented Jul 1, 2020

if a theme declares a bootstrap override path in theme.yaml then that asset should be copied to public on install or it will not be available when needed.

refs #4366

@craigh craigh added the Bug label Jul 1, 2020
@craigh craigh added this to the 3.0.1 milestone Jul 1, 2020
@craigh craigh self-assigned this Jul 1, 2020
@craigh
Copy link
Member Author

@craigh craigh commented Jul 2, 2020

another option is to require the override path be stated in "zasset" notation e.g. @AcmeFooModule:css/myCustomBootstrap.css

craigh/SimpleScrollTheme@74f2db6

@craigh
Copy link
Member Author

@craigh craigh commented Jul 10, 2020

another option is to require the override path be stated in "zasset" notation

since this would require a change in the Api expectation and break existing themes, this cannot be the current solution.

requiring this change could be done for 4.0.0 though.

craigh added a commit that referenced this issue Jul 10, 2020
* Install extension assets on installation and upgrade fixes #4367
@craigh craigh closed this as completed Jul 10, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

No branches or pull requests

1 participant