Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Categories] CategoriesType Registry always showing. Hidden class missing from Bootstrap 4 #4452

Closed
paustian opened this issue Aug 22, 2020 · 1 comment
Labels
Milestone

Comments

@paustian
Copy link
Member

paustian commented Aug 22, 2020

At this point in the code:

$registryOptions['label_attr'] = !$options['expanded'] ? ['class' => 'hidden'] : [];

The CategoriesType uses the Bootstrap hidden css that no longer exists to hide the registry title. Thus, it always shows up no matter what.

Q A
Zikula Version 3.0.1
PHP Version 7.3.9

Expected Behavior

CategoriesType Registry titles should not show unless showRegistryLabels is set to true.

Current Behavior

The registry label always shows. It should not if showRegistryLabels is set to false

Possible Solution

Either find or create a css class that always hides the label

@paustian paustian added the Bug label Aug 22, 2020
@craigh
Copy link
Member

craigh commented Aug 22, 2020

try changing to d-none

https://getbootstrap.com/docs/4.0/utilities/display/

@craigh craigh added this to the 3.0.2 milestone Aug 22, 2020
@craigh craigh changed the title CategoriesType Registry always showing. Hidden class missing from Bootstraph 4 [Categories] CategoriesType Registry always showing. Hidden class missing from Bootstrap 4 Aug 22, 2020
@craigh craigh closed this as completed Aug 22, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

No branches or pull requests

2 participants