Skip to content
This repository

Upgrade to Doctrine 2.3 #545

Closed
drak opened this Issue · 6 comments

3 participants

Drak phaidon Axel Guckelsberger
Drak
Owner

Please upgrade to Doctrine 2.3 (doctrine, dbal and common) and the Doctrine Extension also to the latest. I'm looking for someone to submit a PR for this because I don't have time. Target the 1.4 branch.

Drak drak closed this in 11399eb
phaidon phaidon reopened this
phaidon
Owner

Fatal error: Declaration of DoctrineExtensions\StandardFields\Mapping\Driver\Annotation::readExtendedMetadata() must be compatible with that of Gedmo\Mapping\Driver::readExtendedMetadata() in plugins/DoctrineExtensions/lib/DoctrineExtensions/StandardFields/Mapping/Driver/Annotation.php on line 17

Axel Guckelsberger
Collaborator

Seems like the standard fields listener needs to be updated.

phaidon
Owner

In plugins/DoctrineExtensions/lib/DoctrineExtensions/StandardFields/Mapping/Driver/Annotation.php I changed

public function readExtendedMetadata(ClassMetadata $meta, array &$config) {

to

public function readExtendedMetadata($meta, array &$config) {

This solves the issue. But I am not sure if this is all. Do we have to change validateFullMetadata as well?

phaidon
Owner

Btw. Doctrine 2.3 is more strict.

@ORM\Column(type="integer", length="11", nullable="true")

will not accepted anymore. It has to be like that now

@ORM\Column(type="integer", length=11, nullable=true)

Some modules (e.g. Scribite) has problems with that.

phaidon
Owner

Btw. The Gedmo NestedTree does not work probably with Doctrine 2.2. The tree will not build correctly. With Doctrine 2.3 it works.

phaidon
Owner

The paginator (\DoctrineExtensions\Paginate\Paginate::getPaginateQuery) does not work anymore with 2.3, too.

Now you have to use this one: http://docs.doctrine-project.org/projects/doctrine-orm/en/latest/tutorials/pagination.html

But it seams that this one also works with 2.2.

phaidon phaidon closed this
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Something went wrong with that request. Please try again.