New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

avoid server path exposure in JS asset merger #3890

Merged
merged 1 commit into from Jan 27, 2018

Conversation

Projects
None yet
2 participants
@Guite
Copy link
Member

Guite commented Jan 14, 2018

Q A
Bug fix? yes
New feature? no
BC breaks? no
Deprecations? no
Fixed tickets #3883
Refs tickets -
License MIT
Changelog updated yes

Successfully tested.

@Guite Guite added this to the 1.5.5 milestone Jan 14, 2018

@Guite Guite requested a review from craigh Jan 14, 2018

@craigh
Copy link
Member

craigh left a comment

please correct StyleCI failures.

@craigh

This comment has been minimized.

Copy link
Member

craigh commented Jan 14, 2018

please correct StyleCI failures.

maybe in a separate commit or by negating the new rule that is causing the failures...

@Guite

This comment has been minimized.

Copy link
Member

Guite commented Jan 18, 2018

negating the new rule that is causing the failures

No idea about the new rule because there is nothing shown at https://styleci.readme.io/docs/change-log

@Guite

This comment has been minimized.

Copy link
Member

Guite commented Jan 18, 2018

Sent a mail to them asking for how to ignore that new behaviour.

@Guite Guite merged commit 2522a20 into 1.5 Jan 27, 2018

4 of 7 checks passed

SensioLabsInsight Code quality below expectations.
Details
continuous-integration/styleci/pr The StyleCI analysis has failed - 9 files need addressing
Details
continuous-integration/styleci/push The StyleCI analysis has failed - 9 files need addressing
Details
clahub All contributors have signed the Contributor License Agreement.
Details
continuous-integration/jenkins/branch This commit looks good
Details
continuous-integration/travis-ci/pr The Travis CI build passed
Details
continuous-integration/travis-ci/push The Travis CI build passed
Details

@Guite Guite deleted the issue-3883 branch Jan 27, 2018

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment