New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

updated to Symfony 3.4.6 #3894

Merged
merged 3 commits into from Mar 16, 2018

Conversation

Projects
None yet
2 participants
@Guite
Copy link
Member

Guite commented Mar 15, 2018

Q A
Bug fix? no
New feature? no
BC breaks? yes
Deprecations? no
Fixed tickets -
Refs tickets -
License MIT
Changelog updated yes

Description

Removed custom container builder bridge in order to resolve exceptions in Symfony 3.4.5 and 3.4.6.

@Guite Guite added this to the 2.0.6 milestone Mar 15, 2018

@Guite Guite requested a review from craigh Mar 15, 2018

@craigh

craigh approved these changes Mar 15, 2018

Copy link
Member

craigh left a comment

seems OK. I don't know why the custom was needed...

@craigh

This comment has been minimized.

Copy link
Member

craigh commented Mar 16, 2018

I don't know why the custom was needed...

It looks like drak wanted the ArrayAccess features on the ContainerBuilder. I don't remember ever using this feature, but you might at least make a cursory check for this. Also, you may indicate this specific loss of functionality in the changelog.

@Guite Guite merged commit 66ab15b into 2.0 Mar 16, 2018

3 of 6 checks passed

SensioLabsInsight Analyzing the code.
Details
continuous-integration/travis-ci/pr The Travis CI build is in progress
Details
continuous-integration/travis-ci/push The Travis CI build is in progress
Details
clahub All contributors have signed the Contributor License Agreement.
Details
continuous-integration/styleci/pr The StyleCI analysis has passed
Details
continuous-integration/styleci/push The StyleCI analysis has passed
Details

@Guite Guite deleted the container-builder branch Mar 16, 2018

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment